Browse Source

RDMA/cxgb4: Mark QP in error before disabling the queue in firmware

QPs need to be moved to error before telling the firwmare to shutdown
the queue.  Otherwise, the application can submit WRs that will never
get fetched by the hardware and never flushed by the driver.

Signed-off-by: Kumar Sanghvi <kumaras@chelsio.com>
Acked-by: Steve Wise <swsie@opengridcomputing.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Tom Tucker 14 years ago
parent
commit
d32ae393db
1 changed files with 4 additions and 0 deletions
  1. 4 0
      drivers/infiniband/hw/cxgb4/qp.c

+ 4 - 0
drivers/infiniband/hw/cxgb4/qp.c

@@ -1221,6 +1221,8 @@ int c4iw_modify_qp(struct c4iw_dev *rhp, struct c4iw_qp *qhp,
 				disconnect = 1;
 				disconnect = 1;
 				c4iw_get_ep(&qhp->ep->com);
 				c4iw_get_ep(&qhp->ep->com);
 			}
 			}
+			if (qhp->ibqp.uobject)
+				t4_set_wq_in_error(&qhp->wq);
 			ret = rdma_fini(rhp, qhp, ep);
 			ret = rdma_fini(rhp, qhp, ep);
 			if (ret)
 			if (ret)
 				goto err;
 				goto err;
@@ -1237,6 +1239,8 @@ int c4iw_modify_qp(struct c4iw_dev *rhp, struct c4iw_qp *qhp,
 			break;
 			break;
 		case C4IW_QP_STATE_ERROR:
 		case C4IW_QP_STATE_ERROR:
 			set_state(qhp, C4IW_QP_STATE_ERROR);
 			set_state(qhp, C4IW_QP_STATE_ERROR);
+			if (qhp->ibqp.uobject)
+				t4_set_wq_in_error(&qhp->wq);
 			if (!internal) {
 			if (!internal) {
 				abort = 1;
 				abort = 1;
 				disconnect = 1;
 				disconnect = 1;