浏览代码

PCC: fix dereference of ERR_PTR

get_pcc_channel() does not return NULL on error it returns the error code
in ERR_PTR, but we have been checking it for NULL.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Sudip Mukherjee 10 年之前
父节点
当前提交
d311a28a58
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/mailbox/pcc.c

+ 1 - 1
drivers/mailbox/pcc.c

@@ -122,7 +122,7 @@ struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *cl,
 	 */
 	chan = get_pcc_channel(subspace_id);
 
-	if (!chan || chan->cl) {
+	if (IS_ERR(chan) || chan->cl) {
 		dev_err(dev, "Channel not found for idx: %d\n", subspace_id);
 		return ERR_PTR(-EBUSY);
 	}