Home Explore Help
Sign In
GfA
/
linux_kernel
5
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

drm/i915/bxt: Fix GRC code register field definitions

This has been corrected in BSpec quite some time ago, but we missed it
somehow. The wrong field definitions resulted in configuring PHY0 with
an incorrect GRC value.

v2:
- Remove the FIXME comment, we left in the code exactly about this
  issue. (Ville)

CC: Arthur J Runyan <arthur.j.runyan@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1459515767-29228-3-git-send-email-imre.deak@intel.com
Imre Deak 9 years ago
parent
e7968531f8
commit
d1e082ffb8
1 changed files with 3 additions and 7 deletions
Unified View Show Diff Stats
  1. 3 7
      drivers/gpu/drm/i915/i915_reg.h

+ 3 - 7
drivers/gpu/drm/i915/i915_reg.h
View File 

@@ -1375,14 +1375,10 @@ enum skl_disp_power_wells {
 
 
 
 #define _PORT_REF_DW6_A			0x162198
 
 #define _PORT_REF_DW6_A			0x162198
 
 #define _PORT_REF_DW6_BC		0x6C198
 
 #define _PORT_REF_DW6_BC		0x6C198
 
-/*
 
- * FIXME: BSpec/CHV ConfigDB disagrees on the following two fields, fix them
 
- * after testing.
 
- */
 
-#define   GRC_CODE_SHIFT		23
 
-#define   GRC_CODE_MASK			(0x1FF << GRC_CODE_SHIFT)
 
+#define   GRC_CODE_SHIFT		24
 
+#define   GRC_CODE_MASK			(0xFF << GRC_CODE_SHIFT)
 
 #define   GRC_CODE_FAST_SHIFT		16
 
 #define   GRC_CODE_FAST_SHIFT		16
 
-#define   GRC_CODE_FAST_MASK		(0x7F << GRC_CODE_FAST_SHIFT)
 
+#define   GRC_CODE_FAST_MASK		(0xFF << GRC_CODE_FAST_SHIFT)
 
 #define   GRC_CODE_SLOW_SHIFT		8
 
 #define   GRC_CODE_SLOW_SHIFT		8
 
 #define   GRC_CODE_SLOW_MASK		(0xFF << GRC_CODE_SLOW_SHIFT)
 
 #define   GRC_CODE_SLOW_MASK		(0xFF << GRC_CODE_SLOW_SHIFT)
 
 #define   GRC_CODE_NOM_MASK		0xFF
 
 #define   GRC_CODE_NOM_MASK		0xFF