Bläddra i källkod

Revert "gpio: pca953x: initialize ret to zero to avoid returning garbage"

This reverts commit 313b9a9938bf4076425741121d5d766826793e5d.

This was already fixed by
commit bf62efeb164343916ebb89dca6dfe5e6b6751700
"gpio: pca954x: fix undefined error code from remove"

The latter is a better fix since it makes it easier to detect
erronous code by not assigning a default error code.

Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Linus Walleij 9 år sedan
förälder
incheckning
d147d54899
1 ändrade filer med 1 tillägg och 1 borttagningar
  1. 1 1
      drivers/gpio/gpio-pca953x.c

+ 1 - 1
drivers/gpio/gpio-pca953x.c

@@ -848,7 +848,7 @@ static int pca953x_remove(struct i2c_client *client)
 {
 	struct pca953x_platform_data *pdata = dev_get_platdata(&client->dev);
 	struct pca953x_chip *chip = i2c_get_clientdata(client);
-	int ret = 0;
+	int ret;
 
 	if (pdata && pdata->teardown) {
 		ret = pdata->teardown(client, chip->gpio_chip.base,