瀏覽代碼

i2c: designware: Add debug print for bus speed

Trivial added debug print for dev->clk_freq doesn't necessarily tell the
actual bus speed or mode the controller is operating. For instance it
may indicate 1 MHz Fast Mode Plus or 3.4 MHz High Speed but driver ends up
using 400 kHz Fast Mode due missing timing parameters or missing support
from HW.

Add a debug print that prints the bus speed based on the validated speed
that gets programmed into a HW.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Jarkko Nikula 7 年之前
父節點
當前提交
d07bdbc02c
共有 1 個文件被更改,包括 19 次插入2 次删除
  1. 19 2
      drivers/i2c/busses/i2c-designware-master.c

+ 19 - 2
drivers/i2c/busses/i2c-designware-master.c

@@ -48,7 +48,7 @@ static void i2c_dw_configure_fifo_master(struct dw_i2c_dev *dev)
 static int i2c_dw_set_timings_master(struct dw_i2c_dev *dev)
 static int i2c_dw_set_timings_master(struct dw_i2c_dev *dev)
 {
 {
 	u32 ic_clk = i2c_dw_clk_rate(dev);
 	u32 ic_clk = i2c_dw_clk_rate(dev);
-	const char *fp_str = "";
+	const char *mode_str, *fp_str = "";
 	u32 comp_param1;
 	u32 comp_param1;
 	u32 sda_falling_time, scl_falling_time;
 	u32 sda_falling_time, scl_falling_time;
 	int ret;
 	int ret;
@@ -132,7 +132,24 @@ static int i2c_dw_set_timings_master(struct dw_i2c_dev *dev)
 		}
 		}
 	}
 	}
 
 
-	return i2c_dw_set_sda_hold(dev);
+	ret = i2c_dw_set_sda_hold(dev);
+	if (ret)
+		goto out;
+
+	switch (dev->master_cfg & DW_IC_CON_SPEED_MASK) {
+	case DW_IC_CON_SPEED_STD:
+		mode_str = "Standard Mode";
+		break;
+	case DW_IC_CON_SPEED_HIGH:
+		mode_str = "High Speed Mode";
+		break;
+	default:
+		mode_str = "Fast Mode";
+	}
+	dev_dbg(dev->dev, "Bus speed: %s%s\n", mode_str, fp_str);
+
+out:
+	return ret;
 }
 }
 
 
 /**
 /**