Browse Source

xen: fix memory leak in __xen_pcibk_add_pci_dev()

It need to free dev_entry when it failed to assign to a new
slot on the virtual PCI bus.

smatch says:
 drivers/xen/xen-pciback/vpci.c:142 __xen_pcibk_add_pci_dev() warn:
possible memory leak of 'dev_entry'

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Daeseok Youn 11 years ago
parent
commit
cea37f8751
1 changed files with 2 additions and 0 deletions
  1. 2 0
      drivers/xen/xen-pciback/vpci.c

+ 2 - 0
drivers/xen/xen-pciback/vpci.c

@@ -137,6 +137,8 @@ unlock:
 	/* Publish this device. */
 	/* Publish this device. */
 	if (!err)
 	if (!err)
 		err = publish_cb(pdev, 0, 0, PCI_DEVFN(slot, func), devid);
 		err = publish_cb(pdev, 0, 0, PCI_DEVFN(slot, func), devid);
+	else
+		kfree(dev_entry);
 
 
 out:
 out:
 	return err;
 	return err;