Browse Source

pinctrl: nsp-gpio: forever loop in nsp_gpio_get_strength()

There is a signedness bug here so the loop will never exit.

Fixes: 8bfcbbbcabe0 ('pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Dan Carpenter 9 years ago
parent
commit
ce6c1cd2c3
1 changed files with 2 additions and 1 deletions
  1. 2 1
      drivers/pinctrl/bcm/pinctrl-nsp-gpio.c

+ 2 - 1
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c

@@ -439,9 +439,10 @@ static int nsp_gpio_set_strength(struct nsp_gpio *chip, unsigned gpio,
 static int nsp_gpio_get_strength(struct nsp_gpio *chip, unsigned gpio,
 static int nsp_gpio_get_strength(struct nsp_gpio *chip, unsigned gpio,
 				 u16 *strength)
 				 u16 *strength)
 {
 {
-	unsigned int i, offset, shift;
+	unsigned int offset, shift;
 	u32 val;
 	u32 val;
 	unsigned long flags;
 	unsigned long flags;
+	int i;
 
 
 	offset = NSP_GPIO_DRV_CTRL;
 	offset = NSP_GPIO_DRV_CTRL;
 	shift = gpio;
 	shift = gpio;