Browse Source

rtlwifi: pass struct rtl_stats by reference as it is more efficient

passing rtl_stats by value is inefficient; the structure is over 300
bytes in size and generally just one field (packet_report_type)
is being accessed, so the pass by value is a relatively large overhead.
This change just affects just the rx_command_packet calls.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Colin Ian King 9 years ago
parent
commit
ce2542435a

+ 1 - 1
drivers/net/wireless/realtek/rtlwifi/pci.c

@@ -855,7 +855,7 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw)
 		}
 		}
 		/* handle command packet here */
 		/* handle command packet here */
 		if (rtlpriv->cfg->ops->rx_command_packet &&
 		if (rtlpriv->cfg->ops->rx_command_packet &&
-		    rtlpriv->cfg->ops->rx_command_packet(hw, stats, skb)) {
+		    rtlpriv->cfg->ops->rx_command_packet(hw, &stats, skb)) {
 				dev_kfree_skb_any(skb);
 				dev_kfree_skb_any(skb);
 				goto new_trx_end;
 				goto new_trx_end;
 		}
 		}

+ 1 - 1
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c

@@ -851,7 +851,7 @@ void rtl88ee_tx_polling(struct ieee80211_hw *hw, u8 hw_queue)
 }
 }
 
 
 u32 rtl88ee_rx_command_packet(struct ieee80211_hw *hw,
 u32 rtl88ee_rx_command_packet(struct ieee80211_hw *hw,
-			      struct rtl_stats status,
+			      const struct rtl_stats *status,
 			      struct sk_buff *skb)
 			      struct sk_buff *skb)
 {
 {
 	return 0;
 	return 0;

+ 1 - 1
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.h

@@ -790,7 +790,7 @@ void rtl88ee_tx_fill_cmddesc(struct ieee80211_hw *hw, u8 *pdesc,
 			     bool firstseg, bool lastseg,
 			     bool firstseg, bool lastseg,
 			     struct sk_buff *skb);
 			     struct sk_buff *skb);
 u32 rtl88ee_rx_command_packet(struct ieee80211_hw *hw,
 u32 rtl88ee_rx_command_packet(struct ieee80211_hw *hw,
-			      struct rtl_stats status,
+			      const struct rtl_stats *status,
 			      struct sk_buff *skb);
 			      struct sk_buff *skb);
 
 
 #endif
 #endif

+ 3 - 3
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c

@@ -1105,13 +1105,13 @@ void rtl92ee_tx_polling(struct ieee80211_hw *hw, u8 hw_queue)
 }
 }
 
 
 u32 rtl92ee_rx_command_packet(struct ieee80211_hw *hw,
 u32 rtl92ee_rx_command_packet(struct ieee80211_hw *hw,
-			      struct rtl_stats status,
+			      const struct rtl_stats *status,
 			      struct sk_buff *skb)
 			      struct sk_buff *skb)
 {
 {
 	u32 result = 0;
 	u32 result = 0;
 	struct rtl_priv *rtlpriv = rtl_priv(hw);
 	struct rtl_priv *rtlpriv = rtl_priv(hw);
 
 
-	switch (status.packet_report_type) {
+	switch (status->packet_report_type) {
 	case NORMAL_RX:
 	case NORMAL_RX:
 		result = 0;
 		result = 0;
 		break;
 		break;
@@ -1121,7 +1121,7 @@ u32 rtl92ee_rx_command_packet(struct ieee80211_hw *hw,
 		break;
 		break;
 	default:
 	default:
 		RT_TRACE(rtlpriv, COMP_RECV, DBG_TRACE,
 		RT_TRACE(rtlpriv, COMP_RECV, DBG_TRACE,
-			 "Unknown packet type %d\n", status.packet_report_type);
+			 "Unknown packet type %d\n", status->packet_report_type);
 		break;
 		break;
 	}
 	}
 
 

+ 1 - 1
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.h

@@ -857,6 +857,6 @@ void rtl92ee_tx_fill_cmddesc(struct ieee80211_hw *hw, u8 *pdesc,
 			     bool firstseg, bool lastseg,
 			     bool firstseg, bool lastseg,
 			     struct sk_buff *skb);
 			     struct sk_buff *skb);
 u32 rtl92ee_rx_command_packet(struct ieee80211_hw *hw,
 u32 rtl92ee_rx_command_packet(struct ieee80211_hw *hw,
-			      struct rtl_stats status,
+			      const struct rtl_stats *status,
 			      struct sk_buff *skb);
 			      struct sk_buff *skb);
 #endif
 #endif

+ 1 - 1
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c

@@ -710,7 +710,7 @@ void rtl8723e_tx_polling(struct ieee80211_hw *hw, u8 hw_queue)
 }
 }
 
 
 u32 rtl8723e_rx_command_packet(struct ieee80211_hw *hw,
 u32 rtl8723e_rx_command_packet(struct ieee80211_hw *hw,
-			       struct rtl_stats status,
+			       const struct rtl_stats *status,
 			       struct sk_buff *skb)
 			       struct sk_buff *skb)
 {
 {
 	return 0;
 	return 0;

+ 1 - 1
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.h

@@ -716,6 +716,6 @@ void rtl8723e_tx_fill_cmddesc(struct ieee80211_hw *hw, u8 *pdesc,
 			      bool firstseg, bool lastseg,
 			      bool firstseg, bool lastseg,
 			      struct sk_buff *skb);
 			      struct sk_buff *skb);
 u32 rtl8723e_rx_command_packet(struct ieee80211_hw *hw,
 u32 rtl8723e_rx_command_packet(struct ieee80211_hw *hw,
-			       struct rtl_stats status,
+			       const struct rtl_stats *status,
 			       struct sk_buff *skb);
 			       struct sk_buff *skb);
 #endif
 #endif

+ 2 - 2
drivers/net/wireless/realtek/rtlwifi/rtl8723be/trx.c

@@ -758,13 +758,13 @@ void rtl8723be_tx_polling(struct ieee80211_hw *hw, u8 hw_queue)
 }
 }
 
 
 u32 rtl8723be_rx_command_packet(struct ieee80211_hw *hw,
 u32 rtl8723be_rx_command_packet(struct ieee80211_hw *hw,
-				struct rtl_stats status,
+				const struct rtl_stats *status,
 				struct sk_buff *skb)
 				struct sk_buff *skb)
 {
 {
 	u32 result = 0;
 	u32 result = 0;
 	struct rtl_priv *rtlpriv = rtl_priv(hw);
 	struct rtl_priv *rtlpriv = rtl_priv(hw);
 
 
-	switch (status.packet_report_type) {
+	switch (status->packet_report_type) {
 	case NORMAL_RX:
 	case NORMAL_RX:
 			result = 0;
 			result = 0;
 			break;
 			break;

+ 1 - 1
drivers/net/wireless/realtek/rtlwifi/rtl8723be/trx.h

@@ -620,6 +620,6 @@ void rtl8723be_tx_fill_cmddesc(struct ieee80211_hw *hw, u8 *pdesc,
 			       bool firstseg, bool lastseg,
 			       bool firstseg, bool lastseg,
 			       struct sk_buff *skb);
 			       struct sk_buff *skb);
 u32 rtl8723be_rx_command_packet(struct ieee80211_hw *hw,
 u32 rtl8723be_rx_command_packet(struct ieee80211_hw *hw,
-				struct rtl_stats status,
+				const struct rtl_stats *status,
 				struct sk_buff *skb);
 				struct sk_buff *skb);
 #endif
 #endif

+ 2 - 2
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/trx.c

@@ -998,13 +998,13 @@ void rtl8821ae_tx_polling(struct ieee80211_hw *hw, u8 hw_queue)
 }
 }
 
 
 u32 rtl8821ae_rx_command_packet(struct ieee80211_hw *hw,
 u32 rtl8821ae_rx_command_packet(struct ieee80211_hw *hw,
-				struct rtl_stats status,
+				const struct rtl_stats *status,
 				struct sk_buff *skb)
 				struct sk_buff *skb)
 {
 {
 	u32 result = 0;
 	u32 result = 0;
 	struct rtl_priv *rtlpriv = rtl_priv(hw);
 	struct rtl_priv *rtlpriv = rtl_priv(hw);
 
 
-	switch (status.packet_report_type) {
+	switch (status->packet_report_type) {
 	case NORMAL_RX:
 	case NORMAL_RX:
 		result = 0;
 		result = 0;
 		break;
 		break;

+ 1 - 1
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/trx.h

@@ -615,6 +615,6 @@ void rtl8821ae_tx_fill_cmddesc(struct ieee80211_hw *hw, u8 *pdesc,
 			       bool firstseg, bool lastseg,
 			       bool firstseg, bool lastseg,
 			       struct sk_buff *skb);
 			       struct sk_buff *skb);
 u32 rtl8821ae_rx_command_packet(struct ieee80211_hw *hw,
 u32 rtl8821ae_rx_command_packet(struct ieee80211_hw *hw,
-				struct rtl_stats status,
+				const struct rtl_stats *status,
 				struct sk_buff *skb);
 				struct sk_buff *skb);
 #endif
 #endif

+ 1 - 1
drivers/net/wireless/realtek/rtlwifi/wifi.h

@@ -2189,7 +2189,7 @@ struct rtl_hal_ops {
 	bool (*get_btc_status) (void);
 	bool (*get_btc_status) (void);
 	bool (*is_fw_header)(struct rtlwifi_firmware_header *hdr);
 	bool (*is_fw_header)(struct rtlwifi_firmware_header *hdr);
 	u32 (*rx_command_packet)(struct ieee80211_hw *hw,
 	u32 (*rx_command_packet)(struct ieee80211_hw *hw,
-				 struct rtl_stats status, struct sk_buff *skb);
+				 const struct rtl_stats *status, struct sk_buff *skb);
 	void (*add_wowlan_pattern)(struct ieee80211_hw *hw,
 	void (*add_wowlan_pattern)(struct ieee80211_hw *hw,
 				   struct rtl_wow_pattern *rtl_pattern,
 				   struct rtl_wow_pattern *rtl_pattern,
 				   u8 index);
 				   u8 index);