Jelajahi Sumber

usb: gadget: f_printer: eliminate abuse of ep->driver data

Since ep->driver_data is not used for endpoint claiming, neither for
enabled/disabled state storing, we can reduce number of places where
we read or modify it's value, as now it has no particular meaning for
function or framework logic.

In case of f_printer we only need to store in ep->driver_data pointer to
struct printer_dev, as it's used in rx_complete() and tx_complete()
callbacks. All other uses of ep->driver_data are now meaningless and can
be safely removed.

Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Robert Baldyga 10 tahun lalu
induk
melakukan
ce21a98942
1 mengubah file dengan 0 tambahan dan 2 penghapusan
  1. 0 2
      drivers/usb/gadget/function/f_printer.c

+ 0 - 2
drivers/usb/gadget/function/f_printer.c

@@ -1039,12 +1039,10 @@ autoconf_fail:
 			cdev->gadget->name);
 			cdev->gadget->name);
 		return -ENODEV;
 		return -ENODEV;
 	}
 	}
-	in_ep->driver_data = in_ep;	/* claim */
 
 
 	out_ep = usb_ep_autoconfig(cdev->gadget, &fs_ep_out_desc);
 	out_ep = usb_ep_autoconfig(cdev->gadget, &fs_ep_out_desc);
 	if (!out_ep)
 	if (!out_ep)
 		goto autoconf_fail;
 		goto autoconf_fail;
-	out_ep->driver_data = out_ep;	/* claim */
 
 
 	/* assumes that all endpoints are dual-speed */
 	/* assumes that all endpoints are dual-speed */
 	hs_ep_in_desc.bEndpointAddress = fs_ep_in_desc.bEndpointAddress;
 	hs_ep_in_desc.bEndpointAddress = fs_ep_in_desc.bEndpointAddress;