Sfoglia il codice sorgente

ACM gadget: fix endianness in notifications

The gadget code exports the bitfield for serial status changes
over the wire in its internal endianness. The fix is to convert
to little endian before sending it over the wire.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Tested-by: 家瑋 <momo1208@gmail.com>
CC: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oliver Neukum 8 anni fa
parent
commit
cdd7928df0
1 ha cambiato i file con 3 aggiunte e 1 eliminazioni
  1. 3 1
      drivers/usb/gadget/function/f_acm.c

+ 3 - 1
drivers/usb/gadget/function/f_acm.c

@@ -535,13 +535,15 @@ static int acm_notify_serial_state(struct f_acm *acm)
 {
 {
 	struct usb_composite_dev *cdev = acm->port.func.config->cdev;
 	struct usb_composite_dev *cdev = acm->port.func.config->cdev;
 	int			status;
 	int			status;
+	__le16			serial_state;
 
 
 	spin_lock(&acm->lock);
 	spin_lock(&acm->lock);
 	if (acm->notify_req) {
 	if (acm->notify_req) {
 		dev_dbg(&cdev->gadget->dev, "acm ttyGS%d serial state %04x\n",
 		dev_dbg(&cdev->gadget->dev, "acm ttyGS%d serial state %04x\n",
 			acm->port_num, acm->serial_state);
 			acm->port_num, acm->serial_state);
+		serial_state = cpu_to_le16(acm->serial_state);
 		status = acm_cdc_notify(acm, USB_CDC_NOTIFY_SERIAL_STATE,
 		status = acm_cdc_notify(acm, USB_CDC_NOTIFY_SERIAL_STATE,
-				0, &acm->serial_state, sizeof(acm->serial_state));
+				0, &serial_state, sizeof(acm->serial_state));
 	} else {
 	} else {
 		acm->pending = true;
 		acm->pending = true;
 		status = 0;
 		status = 0;