Browse Source

pinctrl: baytrail: Add missing spinlock usage in byt_gpio_irq_handler

According to VLI64 Intel Atom E3800 Specification Update (#329901)
concurrent read accesses may result in returning 0xffffffff and write
accesses may be dropped silently.
To workaround all accesses must be protected by locks.

Cc: stable@vger.kernel.org
Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Alexander Stein 8 years ago
parent
commit
cdca06e4e8
1 changed files with 2 additions and 0 deletions
  1. 2 0
      drivers/pinctrl/intel/pinctrl-baytrail.c

+ 2 - 0
drivers/pinctrl/intel/pinctrl-baytrail.c

@@ -1623,7 +1623,9 @@ static void byt_gpio_irq_handler(struct irq_desc *desc)
 			continue;
 			continue;
 		}
 		}
 
 
+		raw_spin_lock(&vg->lock);
 		pending = readl(reg);
 		pending = readl(reg);
+		raw_spin_unlock(&vg->lock);
 		for_each_set_bit(pin, &pending, 32) {
 		for_each_set_bit(pin, &pending, 32) {
 			virq = irq_find_mapping(vg->chip.irqdomain, base + pin);
 			virq = irq_find_mapping(vg->chip.irqdomain, base + pin);
 			generic_handle_irq(virq);
 			generic_handle_irq(virq);