|
@@ -538,7 +538,6 @@ static int _rbd_dev_v2_snap_size(struct rbd_device *rbd_dev, u64 snap_id,
|
|
u8 *order, u64 *snap_size);
|
|
u8 *order, u64 *snap_size);
|
|
static int _rbd_dev_v2_snap_features(struct rbd_device *rbd_dev, u64 snap_id,
|
|
static int _rbd_dev_v2_snap_features(struct rbd_device *rbd_dev, u64 snap_id,
|
|
u64 *snap_features);
|
|
u64 *snap_features);
|
|
-static u64 rbd_snap_id_by_name(struct rbd_device *rbd_dev, const char *name);
|
|
|
|
|
|
|
|
static int rbd_open(struct block_device *bdev, fmode_t mode)
|
|
static int rbd_open(struct block_device *bdev, fmode_t mode)
|
|
{
|
|
{
|
|
@@ -3127,9 +3126,6 @@ static void rbd_watch_cb(u64 ver, u64 notify_id, u8 opcode, void *data)
|
|
struct rbd_device *rbd_dev = (struct rbd_device *)data;
|
|
struct rbd_device *rbd_dev = (struct rbd_device *)data;
|
|
int ret;
|
|
int ret;
|
|
|
|
|
|
- if (!rbd_dev)
|
|
|
|
- return;
|
|
|
|
-
|
|
|
|
dout("%s: \"%s\" notify_id %llu opcode %u\n", __func__,
|
|
dout("%s: \"%s\" notify_id %llu opcode %u\n", __func__,
|
|
rbd_dev->header_name, (unsigned long long)notify_id,
|
|
rbd_dev->header_name, (unsigned long long)notify_id,
|
|
(unsigned int)opcode);
|
|
(unsigned int)opcode);
|
|
@@ -3263,6 +3259,9 @@ static void rbd_dev_header_unwatch_sync(struct rbd_device *rbd_dev)
|
|
|
|
|
|
ceph_osdc_cancel_event(rbd_dev->watch_event);
|
|
ceph_osdc_cancel_event(rbd_dev->watch_event);
|
|
rbd_dev->watch_event = NULL;
|
|
rbd_dev->watch_event = NULL;
|
|
|
|
+
|
|
|
|
+ dout("%s flushing notifies\n", __func__);
|
|
|
|
+ ceph_osdc_flush_notifies(&rbd_dev->rbd_client->client->osdc);
|
|
}
|
|
}
|
|
|
|
|
|
/*
|
|
/*
|
|
@@ -3642,21 +3641,14 @@ static void rbd_exists_validate(struct rbd_device *rbd_dev)
|
|
static void rbd_dev_update_size(struct rbd_device *rbd_dev)
|
|
static void rbd_dev_update_size(struct rbd_device *rbd_dev)
|
|
{
|
|
{
|
|
sector_t size;
|
|
sector_t size;
|
|
- bool removing;
|
|
|
|
|
|
|
|
/*
|
|
/*
|
|
- * Don't hold the lock while doing disk operations,
|
|
|
|
- * or lock ordering will conflict with the bdev mutex via:
|
|
|
|
- * rbd_add() -> blkdev_get() -> rbd_open()
|
|
|
|
|
|
+ * If EXISTS is not set, rbd_dev->disk may be NULL, so don't
|
|
|
|
+ * try to update its size. If REMOVING is set, updating size
|
|
|
|
+ * is just useless work since the device can't be opened.
|
|
*/
|
|
*/
|
|
- spin_lock_irq(&rbd_dev->lock);
|
|
|
|
- removing = test_bit(RBD_DEV_FLAG_REMOVING, &rbd_dev->flags);
|
|
|
|
- spin_unlock_irq(&rbd_dev->lock);
|
|
|
|
- /*
|
|
|
|
- * If the device is being removed, rbd_dev->disk has
|
|
|
|
- * been destroyed, so don't try to update its size
|
|
|
|
- */
|
|
|
|
- if (!removing) {
|
|
|
|
|
|
+ if (test_bit(RBD_DEV_FLAG_EXISTS, &rbd_dev->flags) &&
|
|
|
|
+ !test_bit(RBD_DEV_FLAG_REMOVING, &rbd_dev->flags)) {
|
|
size = (sector_t)rbd_dev->mapping.size / SECTOR_SIZE;
|
|
size = (sector_t)rbd_dev->mapping.size / SECTOR_SIZE;
|
|
dout("setting size to %llu sectors", (unsigned long long)size);
|
|
dout("setting size to %llu sectors", (unsigned long long)size);
|
|
set_capacity(rbd_dev->disk, size);
|
|
set_capacity(rbd_dev->disk, size);
|
|
@@ -4191,7 +4183,7 @@ static int _rbd_dev_v2_snap_features(struct rbd_device *rbd_dev, u64 snap_id,
|
|
__le64 features;
|
|
__le64 features;
|
|
__le64 incompat;
|
|
__le64 incompat;
|
|
} __attribute__ ((packed)) features_buf = { 0 };
|
|
} __attribute__ ((packed)) features_buf = { 0 };
|
|
- u64 incompat;
|
|
|
|
|
|
+ u64 unsup;
|
|
int ret;
|
|
int ret;
|
|
|
|
|
|
ret = rbd_obj_method_sync(rbd_dev, rbd_dev->header_name,
|
|
ret = rbd_obj_method_sync(rbd_dev, rbd_dev->header_name,
|
|
@@ -4204,9 +4196,12 @@ static int _rbd_dev_v2_snap_features(struct rbd_device *rbd_dev, u64 snap_id,
|
|
if (ret < sizeof (features_buf))
|
|
if (ret < sizeof (features_buf))
|
|
return -ERANGE;
|
|
return -ERANGE;
|
|
|
|
|
|
- incompat = le64_to_cpu(features_buf.incompat);
|
|
|
|
- if (incompat & ~RBD_FEATURES_SUPPORTED)
|
|
|
|
|
|
+ unsup = le64_to_cpu(features_buf.incompat) & ~RBD_FEATURES_SUPPORTED;
|
|
|
|
+ if (unsup) {
|
|
|
|
+ rbd_warn(rbd_dev, "image uses unsupported features: 0x%llx",
|
|
|
|
+ unsup);
|
|
return -ENXIO;
|
|
return -ENXIO;
|
|
|
|
+ }
|
|
|
|
|
|
*snap_features = le64_to_cpu(features_buf.features);
|
|
*snap_features = le64_to_cpu(features_buf.features);
|
|
|
|
|
|
@@ -5187,6 +5182,10 @@ out_err:
|
|
return ret;
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
|
|
|
|
+/*
|
|
|
|
+ * rbd_dev->header_rwsem must be locked for write and will be unlocked
|
|
|
|
+ * upon return.
|
|
|
|
+ */
|
|
static int rbd_dev_device_setup(struct rbd_device *rbd_dev)
|
|
static int rbd_dev_device_setup(struct rbd_device *rbd_dev)
|
|
{
|
|
{
|
|
int ret;
|
|
int ret;
|
|
@@ -5195,7 +5194,7 @@ static int rbd_dev_device_setup(struct rbd_device *rbd_dev)
|
|
|
|
|
|
ret = rbd_dev_id_get(rbd_dev);
|
|
ret = rbd_dev_id_get(rbd_dev);
|
|
if (ret)
|
|
if (ret)
|
|
- return ret;
|
|
|
|
|
|
+ goto err_out_unlock;
|
|
|
|
|
|
BUILD_BUG_ON(DEV_NAME_LEN
|
|
BUILD_BUG_ON(DEV_NAME_LEN
|
|
< sizeof (RBD_DRV_NAME) + MAX_INT_FORMAT_WIDTH);
|
|
< sizeof (RBD_DRV_NAME) + MAX_INT_FORMAT_WIDTH);
|
|
@@ -5236,8 +5235,9 @@ static int rbd_dev_device_setup(struct rbd_device *rbd_dev)
|
|
/* Everything's ready. Announce the disk to the world. */
|
|
/* Everything's ready. Announce the disk to the world. */
|
|
|
|
|
|
set_bit(RBD_DEV_FLAG_EXISTS, &rbd_dev->flags);
|
|
set_bit(RBD_DEV_FLAG_EXISTS, &rbd_dev->flags);
|
|
- add_disk(rbd_dev->disk);
|
|
|
|
|
|
+ up_write(&rbd_dev->header_rwsem);
|
|
|
|
|
|
|
|
+ add_disk(rbd_dev->disk);
|
|
pr_info("%s: added with size 0x%llx\n", rbd_dev->disk->disk_name,
|
|
pr_info("%s: added with size 0x%llx\n", rbd_dev->disk->disk_name,
|
|
(unsigned long long) rbd_dev->mapping.size);
|
|
(unsigned long long) rbd_dev->mapping.size);
|
|
|
|
|
|
@@ -5252,6 +5252,8 @@ err_out_blkdev:
|
|
unregister_blkdev(rbd_dev->major, rbd_dev->name);
|
|
unregister_blkdev(rbd_dev->major, rbd_dev->name);
|
|
err_out_id:
|
|
err_out_id:
|
|
rbd_dev_id_put(rbd_dev);
|
|
rbd_dev_id_put(rbd_dev);
|
|
|
|
+err_out_unlock:
|
|
|
|
+ up_write(&rbd_dev->header_rwsem);
|
|
return ret;
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
|
|
@@ -5442,6 +5444,7 @@ static ssize_t do_rbd_add(struct bus_type *bus,
|
|
spec = NULL; /* rbd_dev now owns this */
|
|
spec = NULL; /* rbd_dev now owns this */
|
|
rbd_opts = NULL; /* rbd_dev now owns this */
|
|
rbd_opts = NULL; /* rbd_dev now owns this */
|
|
|
|
|
|
|
|
+ down_write(&rbd_dev->header_rwsem);
|
|
rc = rbd_dev_image_probe(rbd_dev, 0);
|
|
rc = rbd_dev_image_probe(rbd_dev, 0);
|
|
if (rc < 0)
|
|
if (rc < 0)
|
|
goto err_out_rbd_dev;
|
|
goto err_out_rbd_dev;
|
|
@@ -5471,6 +5474,7 @@ out:
|
|
return rc;
|
|
return rc;
|
|
|
|
|
|
err_out_rbd_dev:
|
|
err_out_rbd_dev:
|
|
|
|
+ up_write(&rbd_dev->header_rwsem);
|
|
rbd_dev_destroy(rbd_dev);
|
|
rbd_dev_destroy(rbd_dev);
|
|
err_out_client:
|
|
err_out_client:
|
|
rbd_put_client(rbdc);
|
|
rbd_put_client(rbdc);
|
|
@@ -5577,12 +5581,6 @@ static ssize_t do_rbd_remove(struct bus_type *bus,
|
|
return ret;
|
|
return ret;
|
|
|
|
|
|
rbd_dev_header_unwatch_sync(rbd_dev);
|
|
rbd_dev_header_unwatch_sync(rbd_dev);
|
|
- /*
|
|
|
|
- * flush remaining watch callbacks - these must be complete
|
|
|
|
- * before the osd_client is shutdown
|
|
|
|
- */
|
|
|
|
- dout("%s: flushing notifies", __func__);
|
|
|
|
- ceph_osdc_flush_notifies(&rbd_dev->rbd_client->client->osdc);
|
|
|
|
|
|
|
|
/*
|
|
/*
|
|
* Don't free anything from rbd_dev->disk until after all
|
|
* Don't free anything from rbd_dev->disk until after all
|