瀏覽代碼

Input: kbtab - validate number of endpoints before using them

Make sure to check the number of endpoints to avoid dereferencing a
NULL-pointer should a malicious device lack endpoints.

Signed-off-by: Johan Hovold <johan@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Johan Hovold 8 年之前
父節點
當前提交
cb1b494663
共有 1 個文件被更改,包括 3 次插入0 次删除
  1. 3 0
      drivers/input/tablet/kbtab.c

+ 3 - 0
drivers/input/tablet/kbtab.c

@@ -122,6 +122,9 @@ static int kbtab_probe(struct usb_interface *intf, const struct usb_device_id *i
 	struct input_dev *input_dev;
 	struct input_dev *input_dev;
 	int error = -ENOMEM;
 	int error = -ENOMEM;
 
 
+	if (intf->cur_altsetting->desc.bNumEndpoints < 1)
+		return -ENODEV;
+
 	kbtab = kzalloc(sizeof(struct kbtab), GFP_KERNEL);
 	kbtab = kzalloc(sizeof(struct kbtab), GFP_KERNEL);
 	input_dev = input_allocate_device();
 	input_dev = input_allocate_device();
 	if (!kbtab || !input_dev)
 	if (!kbtab || !input_dev)