瀏覽代碼

pNFS/flexfiles: Fix ff_layout_add_ds_error_locked()

When we're merging an old entry into our new entry, we want to ensure that
we add the list entry in the correct place.

Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Trond Myklebust 8 年之前
父節點
當前提交
cb06793517
共有 1 個文件被更改,包括 2 次插入1 次删除
  1. 2 1
      fs/nfs/flexfilelayout/flexfilelayoutdev.c

+ 2 - 1
fs/nfs/flexfilelayout/flexfilelayoutdev.c

@@ -254,8 +254,9 @@ ff_layout_add_ds_error_locked(struct nfs4_flexfile_layout *flo,
 		}
 		}
 		/* Entries match, so merge "err" into "dserr" */
 		/* Entries match, so merge "err" into "dserr" */
 		extend_ds_error(dserr, err->offset, err->length);
 		extend_ds_error(dserr, err->offset, err->length);
-		list_del(&err->list);
+		list_replace(&err->list, &dserr->list);
 		kfree(err);
 		kfree(err);
+		return;
 	}
 	}
 
 
 	list_add_tail(&dserr->list, head);
 	list_add_tail(&dserr->list, head);