浏览代码

rtc: mrst: fix error code in probe()

We should be returning "retval".  The "mrst_rtc.rtc" variable is a valid
pointer.

Fixes: 32b41f93dcaf ("rtc: mrst: switch to devm functions")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Dan Carpenter 7 年之前
父节点
当前提交
ca95ef7c98
共有 1 个文件被更改,包括 1 次插入3 次删除
  1. 1 3
      drivers/rtc/rtc-mrst.c

+ 1 - 3
drivers/rtc/rtc-mrst.c

@@ -367,10 +367,8 @@ static int vrtc_mrst_do_probe(struct device *dev, struct resource *iomem,
 	}
 	}
 
 
 	retval = rtc_register_device(mrst_rtc.rtc);
 	retval = rtc_register_device(mrst_rtc.rtc);
-	if (retval) {
-		retval = PTR_ERR(mrst_rtc.rtc);
+	if (retval)
 		goto cleanup0;
 		goto cleanup0;
-	}
 
 
 	dev_dbg(dev, "initialised\n");
 	dev_dbg(dev, "initialised\n");
 	return 0;
 	return 0;