ソースを参照

GPIO: MIPS: lantiq: fix overflow inside stp-xway driver

The driver was using a 16 bit field for storing the shadow value of the shift
register cascade. This resulted in only the first 2 shift registeres receiving
the correct data. The third shift register would always receive 0x00.

Fix this by using a 32bit field for the shadow value.

Signed-off-by: John Crispin <blogic@openwrt.org>
Cc: linux-kernel@vger.kernel.org
John Crispin 13 年 前
コミット
c9e854cf94
1 ファイル変更1 行追加1 行削除
  1. 1 1
      drivers/gpio/gpio-stp-xway.c

+ 1 - 1
drivers/gpio/gpio-stp-xway.c

@@ -82,7 +82,7 @@ struct xway_stp {
 	struct gpio_chip gc;
 	struct gpio_chip gc;
 	void __iomem *virt;
 	void __iomem *virt;
 	u32 edge;	/* rising or falling edge triggered shift register */
 	u32 edge;	/* rising or falling edge triggered shift register */
-	u16 shadow;	/* shadow the shift registers state */
+	u32 shadow;	/* shadow the shift registers state */
 	u8 groups;	/* we can drive 1-3 groups of 8bit each */
 	u8 groups;	/* we can drive 1-3 groups of 8bit each */
 	u8 dsl;		/* the 2 LSBs can be driven by the dsl core */
 	u8 dsl;		/* the 2 LSBs can be driven by the dsl core */
 	u8 phy1;	/* 3 bits can be driven by phy1 */
 	u8 phy1;	/* 3 bits can be driven by phy1 */