瀏覽代碼

HID: i2c-hid: fix harmless test_bit() issue

These defines are used like this:

	if (test_bit(I2C_HID_STARTED, &ihid->flags))

The intent was to use bits 0, 1, and 2 but because of the extra shifts
we're using bits 1, 2, and 4.  It's harmless becuase it's done
consistently but it's not the intent and static checkers will complain.

Fixes: 4a200c3b9a40 ('HID: i2c-hid: introduce HID over i2c specification implementation')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Dan Carpenter 10 年之前
父節點
當前提交
c8fd51dc12
共有 1 個文件被更改,包括 3 次插入3 次删除
  1. 3 3
      drivers/hid/i2c-hid/i2c-hid.c

+ 3 - 3
drivers/hid/i2c-hid/i2c-hid.c

@@ -42,9 +42,9 @@
 #include <linux/i2c/i2c-hid.h>
 #include <linux/i2c/i2c-hid.h>
 
 
 /* flags */
 /* flags */
-#define I2C_HID_STARTED		(1 << 0)
-#define I2C_HID_RESET_PENDING	(1 << 1)
-#define I2C_HID_READ_PENDING	(1 << 2)
+#define I2C_HID_STARTED		0
+#define I2C_HID_RESET_PENDING	1
+#define I2C_HID_READ_PENDING	2
 
 
 #define I2C_HID_PWR_ON		0x00
 #define I2C_HID_PWR_ON		0x00
 #define I2C_HID_PWR_SLEEP	0x01
 #define I2C_HID_PWR_SLEEP	0x01