Home Explore Help
Sign In
GfA
/
linux_kernel
5
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

staging: dgnc: UART_IIR_XOFF code is buggy

The UART_IIR_XOFF was supposed to be a no-op but, because there was a
missing semi-colon, the if statement is not "Empty".  I have just deleted
this code because it was supposed to be a no-op anyway.  UART_IIR_XOFF
is a standard define and not something specific to this driver.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter 11 years ago
parent
0f33ae1ed6
commit
c80561e96b
2 changed files with 0 additions and 5 deletions
Unified View Show Diff Stats
  1. 0 4
      drivers/staging/dgnc/dgnc_cls.c
  2. 0 1
      drivers/staging/dgnc/dgnc_cls.h

+ 0 - 4
drivers/staging/dgnc/dgnc_cls.c
View File 

@@ -453,10 +453,6 @@ static inline void cls_parse_isr(struct dgnc_board *brd, uint port)
 
 			cls_copy_data_from_queue_to_uart(ch);
 
 			cls_copy_data_from_queue_to_uart(ch);
 
 		}
 
 		}
 
 
 
-		/* Received Xoff signal/Special character */
 
-		if (isr & UART_IIR_XOFF)
 
-			/* Empty */
 
-
 
 		/* CTS/RTS change of state */
 
 		/* CTS/RTS change of state */
 
 		if (isr & UART_IIR_CTSRTS) {
 
 		if (isr & UART_IIR_CTSRTS) {
 
 			brd->intr_modem++;
 
 			brd->intr_modem++;

+ 0 - 1
drivers/staging/dgnc/dgnc_cls.h
View File 

@@ -61,7 +61,6 @@ struct cls_uart_struct {
 
 #define UART_16654_FCR_RXTRIGGER_56	0x80
 
 #define UART_16654_FCR_RXTRIGGER_56	0x80
 
 #define UART_16654_FCR_RXTRIGGER_60     0xC0
 
 #define UART_16654_FCR_RXTRIGGER_60     0xC0
 
 
 
-#define UART_IIR_XOFF			0x10	/* Received Xoff signal/Special character */
 
 #define UART_IIR_CTSRTS			0x20	/* Received CTS/RTS change of state */
 
 #define UART_IIR_CTSRTS			0x20	/* Received CTS/RTS change of state */
 
 #define UART_IIR_RDI_TIMEOUT		0x0C    /* Receiver data TIMEOUT */
 
 #define UART_IIR_RDI_TIMEOUT		0x0C    /* Receiver data TIMEOUT */