瀏覽代碼

net/mlx5e: Remove redundant WARN when we cannot find neigh entry

It is possible for neigh entry not to exist if it was cleaned already.
When we bring down an interface the neigh gets deleted but it could be
that our listener for neigh event to clear the encap valid bit didn't
start yet and the neigh update last used work is started first.
In this scenario the encap entry has valid bit set but the neigh entry
doesn't exist.

Signed-off-by: Roi Dayan <roid@mellanox.com>
Reviewed-by: Paul Blakey <paulb@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Roi Dayan 7 年之前
父節點
當前提交
c7f7ba8df8
共有 1 個文件被更改,包括 1 次插入3 次删除
  1. 1 3
      drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

+ 1 - 3
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

@@ -1032,10 +1032,8 @@ void mlx5e_tc_update_neigh_used_value(struct mlx5e_neigh_hash_entry *nhe)
 		 * dst ip pair
 		 * dst ip pair
 		 */
 		 */
 		n = neigh_lookup(tbl, &m_neigh->dst_ip, m_neigh->dev);
 		n = neigh_lookup(tbl, &m_neigh->dst_ip, m_neigh->dev);
-		if (!n) {
-			WARN(1, "The neighbour already freed\n");
+		if (!n)
 			return;
 			return;
-		}
 
 
 		neigh_event_send(n, NULL);
 		neigh_event_send(n, NULL);
 		neigh_release(n);
 		neigh_release(n);