Browse Source

gpu: ipu-v3: pre: fix device node leak in ipu_pre_lookup_by_phandle

Before returning, call of_node_put() for the device node returned by
of_parse_phandle().

Fixes: d2a34232580a ("gpu: ipu-v3: add driver for Prefetch Resolve Engine")
Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Tobias Jordan 7 years ago
parent
commit
c795f3052b
1 changed files with 3 additions and 0 deletions
  1. 3 0
      drivers/gpu/ipu-v3/ipu-pre.c

+ 3 - 0
drivers/gpu/ipu-v3/ipu-pre.c

@@ -129,11 +129,14 @@ ipu_pre_lookup_by_phandle(struct device *dev, const char *name, int index)
 		if (pre_node == pre->dev->of_node) {
 		if (pre_node == pre->dev->of_node) {
 			mutex_unlock(&ipu_pre_list_mutex);
 			mutex_unlock(&ipu_pre_list_mutex);
 			device_link_add(dev, pre->dev, DL_FLAG_AUTOREMOVE);
 			device_link_add(dev, pre->dev, DL_FLAG_AUTOREMOVE);
+			of_node_put(pre_node);
 			return pre;
 			return pre;
 		}
 		}
 	}
 	}
 	mutex_unlock(&ipu_pre_list_mutex);
 	mutex_unlock(&ipu_pre_list_mutex);
 
 
+	of_node_put(pre_node);
+
 	return NULL;
 	return NULL;
 }
 }