Browse Source

[media] coda: fix the error path in coda_probe()

In the case of coda_firmware_request() failure, we should release the
prevously acquired resources.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Fabio Estevam 8 years ago
parent
commit
c762ff1f7e
1 changed files with 6 additions and 1 deletions
  1. 6 1
      drivers/media/platform/coda/coda-common.c

+ 6 - 1
drivers/media/platform/coda/coda-common.c

@@ -2295,8 +2295,13 @@ static int coda_probe(struct platform_device *pdev)
 	pm_runtime_set_active(&pdev->dev);
 	pm_runtime_set_active(&pdev->dev);
 	pm_runtime_enable(&pdev->dev);
 	pm_runtime_enable(&pdev->dev);
 
 
-	return coda_firmware_request(dev);
+	ret = coda_firmware_request(dev);
+	if (ret)
+		goto err_alloc_workqueue;
+	return 0;
 
 
+err_alloc_workqueue:
+	destroy_workqueue(dev->workqueue);
 err_v4l2_register:
 err_v4l2_register:
 	v4l2_device_unregister(&dev->v4l2_dev);
 	v4l2_device_unregister(&dev->v4l2_dev);
 	return ret;
 	return ret;