Explorar el Código

can: janz-ican3: Fix the usage of wait_for_completion_timeout

The return value of wait_for_completion_timeout() is always
>= 0 with unsigned int type.

So the condition "ret < 0" or "ret >= 0" is pointless.

Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Chuansheng Liu hace 12 años
padre
commit
c70edb9e8a
Se han modificado 1 ficheros con 2 adiciones y 2 borrados
  1. 2 2
      drivers/net/can/janz-ican3.c

+ 2 - 2
drivers/net/can/janz-ican3.c

@@ -1692,7 +1692,7 @@ static int ican3_get_berr_counter(const struct net_device *ndev,
 		return ret;
 		return ret;
 
 
 	ret = wait_for_completion_timeout(&mod->buserror_comp, HZ);
 	ret = wait_for_completion_timeout(&mod->buserror_comp, HZ);
-	if (ret <= 0) {
+	if (ret == 0) {
 		dev_info(mod->dev, "%s timed out\n", __func__);
 		dev_info(mod->dev, "%s timed out\n", __func__);
 		return -ETIMEDOUT;
 		return -ETIMEDOUT;
 	}
 	}
@@ -1718,7 +1718,7 @@ static ssize_t ican3_sysfs_show_term(struct device *dev,
 		return ret;
 		return ret;
 
 
 	ret = wait_for_completion_timeout(&mod->termination_comp, HZ);
 	ret = wait_for_completion_timeout(&mod->termination_comp, HZ);
-	if (ret <= 0) {
+	if (ret == 0) {
 		dev_info(mod->dev, "%s timed out\n", __func__);
 		dev_info(mod->dev, "%s timed out\n", __func__);
 		return -ETIMEDOUT;
 		return -ETIMEDOUT;
 	}
 	}