Browse Source

[media] drivers/media/media-device: move debug log before _devnode_unregister()

After media_devnode_unregister(), the struct media_device may be freed
already, and dereferencing it may crash.

Signed-off-by: Max Kellermann <max@duempel.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Max Kellermann 9 năm trước cách đây
mục cha
commit
c56d34a73e
1 tập tin đã thay đổi với 1 bổ sung2 xóa
  1. 1 2
      drivers/media/media-device.c

+ 1 - 2
drivers/media/media-device.c

@@ -801,9 +801,8 @@ void media_device_unregister(struct media_device *mdev)
 	mutex_unlock(&mdev->graph_mutex);
 
 	device_remove_file(&mdev->devnode.dev, &dev_attr_model);
+	dev_dbg(mdev->dev, "Media device unregistering\n");
 	media_devnode_unregister(&mdev->devnode);
-
-	dev_dbg(mdev->dev, "Media device unregistered\n");
 }
 EXPORT_SYMBOL_GPL(media_device_unregister);