Browse Source

smsc95xx: Check for Wake-on-LAN modes

The driver does not check for Wake-on-LAN modes specified by an user,
but will conditionally set the device as wake-up enabled or not based on
that, which could be a very confusing user experience.

Fixes: e0e474a83c18 ("smsc95xx: add wol magic packet support")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Florian Fainelli 6 years ago
parent
commit
c530c471ba
1 changed files with 3 additions and 0 deletions
  1. 3 0
      drivers/net/usb/smsc95xx.c

+ 3 - 0
drivers/net/usb/smsc95xx.c

@@ -774,6 +774,9 @@ static int smsc95xx_ethtool_set_wol(struct net_device *net,
 	struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]);
 	struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]);
 	int ret;
 	int ret;
 
 
+	if (wolinfo->wolopts & ~SUPPORTED_WAKE)
+		return -EINVAL;
+
 	pdata->wolopts = wolinfo->wolopts & SUPPORTED_WAKE;
 	pdata->wolopts = wolinfo->wolopts & SUPPORTED_WAKE;
 
 
 	ret = device_set_wakeup_enable(&dev->udev->dev, pdata->wolopts);
 	ret = device_set_wakeup_enable(&dev->udev->dev, pdata->wolopts);