Browse Source

of: Delete unnecessary check before calling "of_node_put()"

The of_node_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Grant Likely <grant.likely@linaro.org>
Markus Elfring 10 years ago
parent
commit
c46ca3c831
1 changed files with 1 additions and 2 deletions
  1. 1 2
      drivers/of/unittest.c

+ 1 - 2
drivers/of/unittest.c

@@ -516,8 +516,7 @@ static void __init of_selftest_changeset(void)
 	/* Make sure node names are constructed correctly */
 	/* Make sure node names are constructed correctly */
 	selftest((np = of_find_node_by_path("/testcase-data/changeset/n2/n21")),
 	selftest((np = of_find_node_by_path("/testcase-data/changeset/n2/n21")),
 		 "'%s' not added\n", n21->full_name);
 		 "'%s' not added\n", n21->full_name);
-	if (np)
-		of_node_put(np);
+	of_node_put(np);
 
 
 	mutex_lock(&of_mutex);
 	mutex_lock(&of_mutex);
 	selftest(!of_changeset_revert(&chgset), "revert failed\n");
 	selftest(!of_changeset_revert(&chgset), "revert failed\n");