Browse Source

Input: ads7846 - use PTR_ERR_OR_ZERO()

The PTR_ERR_OR_ZERO() helper function checks if a pointer contains an
errno code and returns it or return 0 if that's not the case. Use the
helper instead of open coding the same logic in the driver. This was
found with make coccicheck that complains with the following warning:

drivers/input/touchscreen/ads7846.c:532:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Javier Martinez Canillas 9 years ago
parent
commit
c4517f82d2
1 changed files with 1 additions and 3 deletions
  1. 1 3
      drivers/input/touchscreen/ads7846.c

+ 1 - 3
drivers/input/touchscreen/ads7846.c

@@ -529,10 +529,8 @@ static int ads784x_hwmon_register(struct spi_device *spi, struct ads7846 *ts)
 
 
 	ts->hwmon = hwmon_device_register_with_groups(&spi->dev, spi->modalias,
 	ts->hwmon = hwmon_device_register_with_groups(&spi->dev, spi->modalias,
 						      ts, ads7846_attr_groups);
 						      ts, ads7846_attr_groups);
-	if (IS_ERR(ts->hwmon))
-		return PTR_ERR(ts->hwmon);
 
 
-	return 0;
+	return PTR_ERR_OR_ZERO(ts->hwmon);
 }
 }
 
 
 static void ads784x_hwmon_unregister(struct spi_device *spi,
 static void ads784x_hwmon_unregister(struct spi_device *spi,