Browse Source

Staging: Gasket: shift wrapping bug in gasket_read_modify_write_64()

This function only has one caller so mask_width is 1 and mask_shift is
32.  Shifting an int by 32 bits is undefined, but I guess on GCC it
wraps to 0x1?  Anyway it's supposed to be 0x100000000.

Fixes: 9a69f5087ccc ("drivers/staging: Gasket driver framework + Apex driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter 7 năm trước cách đây
mục cha
commit
c37a192ef4
1 tập tin đã thay đổi với 1 bổ sung1 xóa
  1. 1 1
      drivers/staging/gasket/gasket_core.h

+ 1 - 1
drivers/staging/gasket/gasket_core.h

@@ -683,7 +683,7 @@ static inline void gasket_read_modify_write_64(
 	u64 mask, tmp;
 
 	tmp = gasket_dev_read_64(dev, bar, location);
-	mask = ((1 << mask_width) - 1) << mask_shift;
+	mask = ((1ULL << mask_width) - 1) << mask_shift;
 	tmp = (tmp & ~mask) | (value << mask_shift);
 	gasket_dev_write_64(dev, tmp, bar, location);
 }