Browse Source

cxgb3: remove VLA usage

Remove VLA usage and change the 'len' argument to a u8 and use a 256
byte buffer on the stack. Notice that these lengths are limited by the
encoding field in the VPD structure, which is a u8 [1].

[1] https://marc.info/?l=linux-netdev&m=152044354814024&w=2

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Gustavo A. R. Silva 7 years ago
parent
commit
c33b3b9fcf
1 changed files with 4 additions and 4 deletions
  1. 4 4
      drivers/net/ethernet/chelsio/cxgb3/t3_hw.c

+ 4 - 4
drivers/net/ethernet/chelsio/cxgb3/t3_hw.c

@@ -681,18 +681,18 @@ int t3_seeprom_wp(struct adapter *adapter, int enable)
 	return t3_seeprom_write(adapter, EEPROM_STAT_ADDR, enable ? 0xc : 0);
 	return t3_seeprom_write(adapter, EEPROM_STAT_ADDR, enable ? 0xc : 0);
 }
 }
 
 
-static int vpdstrtouint(char *s, int len, unsigned int base, unsigned int *val)
+static int vpdstrtouint(char *s, u8 len, unsigned int base, unsigned int *val)
 {
 {
-	char tok[len + 1];
+	char tok[256];
 
 
 	memcpy(tok, s, len);
 	memcpy(tok, s, len);
 	tok[len] = 0;
 	tok[len] = 0;
 	return kstrtouint(strim(tok), base, val);
 	return kstrtouint(strim(tok), base, val);
 }
 }
 
 
-static int vpdstrtou16(char *s, int len, unsigned int base, u16 *val)
+static int vpdstrtou16(char *s, u8 len, unsigned int base, u16 *val)
 {
 {
-	char tok[len + 1];
+	char tok[256];
 
 
 	memcpy(tok, s, len);
 	memcpy(tok, s, len);
 	tok[len] = 0;
 	tok[len] = 0;