浏览代码

bonding: remove the redundant judgements for bond_option_queue_id_set()

The dev_valid_name() will check the buffer length for input name, no need to
check it twice.

Cc: Jay Vosburgh <fubar@us.ibm.com>
Cc: Veaceslav Falico <vfalico@redhat.com>
Cc: Andy Gospodarek <andy@greyhouse.net>
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Reviewed-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
dingtianhong 11 年之前
父节点
当前提交
c313c89edb
共有 1 个文件被更改,包括 1 次插入2 次删除
  1. 1 2
      drivers/net/bonding/bond_options.c

+ 1 - 2
drivers/net/bonding/bond_options.c

@@ -1199,8 +1199,7 @@ int bond_option_queue_id_set(struct bonding *bond,
 		goto err_no_cmd;
 		goto err_no_cmd;
 
 
 	/* Check buffer length, valid ifname and queue id */
 	/* Check buffer length, valid ifname and queue id */
-	if (strlen(newval->string) > IFNAMSIZ ||
-	    !dev_valid_name(newval->string) ||
+	if (!dev_valid_name(newval->string) ||
 	    qid > bond->dev->real_num_tx_queues)
 	    qid > bond->dev->real_num_tx_queues)
 		goto err_no_cmd;
 		goto err_no_cmd;