Просмотр исходного кода

ASoC: Intel: Skylake: Fix memory leak

If snd_soc_tplg_component_load() fails we just printed an error message
and returned the error code but we missed releasing the firmware.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Sudip Mukherjee 9 лет назад
Родитель
Сommit
c14a82c781
1 измененных файлов с 1 добавлено и 0 удалено
  1. 1 0
      sound/soc/intel/skylake/skl-topology.c

+ 1 - 0
sound/soc/intel/skylake/skl-topology.c

@@ -1511,6 +1511,7 @@ int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus)
 	release_firmware(fw);
 	release_firmware(fw);
 	if (ret < 0) {
 	if (ret < 0) {
 		dev_err(bus->dev, "tplg component load failed%d\n", ret);
 		dev_err(bus->dev, "tplg component load failed%d\n", ret);
+		release_firmware(fw);
 		return -EINVAL;
 		return -EINVAL;
 	}
 	}