Explorar o código

firewire: sbp2: replace a GFP_ATOMIC allocation

sbp2_send_management_orb() is called by sbp2_login, sbp2_reconnect, and
sbp2_remove, all which are able to sleep during memory allocations.
Actually, sbp2_send_management_orb() itself is a sleeping function.

Login and remove could allocate with GFP_KERNEL but reconnect needs
GFP_NOIO to ensure progress in low memory situations.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Stefan Richter %!s(int64=13) %!d(string=hai) anos
pai
achega
c13ccfcf66
Modificáronse 1 ficheiros con 1 adicións e 1 borrados
  1. 1 1
      drivers/firewire/sbp2.c

+ 1 - 1
drivers/firewire/sbp2.c

@@ -569,7 +569,7 @@ static int sbp2_send_management_orb(struct sbp2_logical_unit *lu, int node_id,
 	if (function == SBP2_LOGOUT_REQUEST && fw_device_is_shutdown(device))
 		return 0;
 
-	orb = kzalloc(sizeof(*orb), GFP_ATOMIC);
+	orb = kzalloc(sizeof(*orb), GFP_NOIO);
 	if (orb == NULL)
 		return -ENOMEM;