瀏覽代碼

perf report/tui: Fix a bug when --fields/sort is given

The hists__filter_entries() function is called when down arrow key is
pressed for navigating through the entries in TUI.  It has a check for
filtering out entries that have very small overhead (under min_pcnt).

However it just assumed the entries are sorted by the overhead so when
it saw such a small overheaded entry, it just stopped navigating as an
optimization.  But it's not true anymore due to new --fields and
--sort optoin behavior and this case users cannot go down to a next
entry if ther's an entry with small overhead in-between.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1400480762-22852-14-git-send-email-namhyung@kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Namhyung Kim 11 年之前
父節點
當前提交
c0f1527b7e
共有 1 個文件被更改,包括 1 次插入4 次删除
  1. 1 4
      tools/perf/ui/browsers/hists.c

+ 1 - 4
tools/perf/ui/browsers/hists.c

@@ -812,10 +812,7 @@ static struct rb_node *hists__filter_entries(struct rb_node *nd,
 		if (total)
 		if (total)
 			percent = h->stat.period * 100.0 / total;
 			percent = h->stat.period * 100.0 / total;
 
 
-		if (percent < min_pcnt)
-			return NULL;
-
-		if (!h->filtered)
+		if (!h->filtered && percent >= min_pcnt)
 			return nd;
 			return nd;
 
 
 		nd = rb_next(nd);
 		nd = rb_next(nd);