浏览代码

lp5523, lp8501: comment improvements

Add some comments that are not obvious from first look at the driver
to lp5523, fix typo in lp8501.

Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Pavel Machek 11 年之前
父节点
当前提交
bfb18d824c
共有 2 个文件被更改,包括 10 次插入2 次删除
  1. 9 1
      drivers/leds/leds-lp5523.c
  2. 1 1
      drivers/leds/leds-lp8501.c

+ 9 - 1
drivers/leds/leds-lp5523.c

@@ -35,7 +35,15 @@
 
 
 #include "leds-lp55xx-common.h"
 #include "leds-lp55xx-common.h"
 
 
-#define LP5523_PROGRAM_LENGTH		32
+#define LP5523_PROGRAM_LENGTH		32	/* bytes */
+/* Memory is used like this:
+   0x00 engine 1 program
+   0x10 engine 2 program
+   0x20 engine 3 program
+   0x30 engine 1 muxing info
+   0x40 engine 2 muxing info
+   0x50 engine 3 muxing info
+*/
 #define LP5523_MAX_LEDS			9
 #define LP5523_MAX_LEDS			9
 
 
 /* Registers */
 /* Registers */

+ 1 - 1
drivers/leds/leds-lp8501.c

@@ -263,7 +263,7 @@ static void lp8501_firmware_loaded(struct lp55xx_chip *chip)
 	}
 	}
 
 
 	/*
 	/*
-	 * Program momery sequence
+	 * Program memory sequence
 	 *  1) set engine mode to "LOAD"
 	 *  1) set engine mode to "LOAD"
 	 *  2) write firmware data into program memory
 	 *  2) write firmware data into program memory
 	 */
 	 */