Browse Source

usb: core: fix memory leak on port_dev_path allocation

Currently the allocation of port_dev_path from the call to
kobject_get_path is not being kfree'd, causing a memory leak. Fix
this by kfree'ing this at the end of the function. Add an extra
error exit path to fix one of the early leaks when envp[0] fails
to be allocated.

Detected by CoverityScan, CID#1473771 ("Resource Leak")

Fixes: 201af55da8a3 ("usb: core: added uevent for over-current")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King 6 years ago
parent
commit
bf7f547ecd
1 changed files with 3 additions and 1 deletions
  1. 3 1
      drivers/usb/core/hub.c

+ 3 - 1
drivers/usb/core/hub.c

@@ -5170,7 +5170,7 @@ static void port_over_current_notify(struct usb_port *port_dev)
 
 
 	envp[0] = kasprintf(GFP_KERNEL, "OVER_CURRENT_PORT=%s", port_dev_path);
 	envp[0] = kasprintf(GFP_KERNEL, "OVER_CURRENT_PORT=%s", port_dev_path);
 	if (!envp[0])
 	if (!envp[0])
-		return;
+		goto exit_path;
 
 
 	envp[1] = kasprintf(GFP_KERNEL, "OVER_CURRENT_COUNT=%u",
 	envp[1] = kasprintf(GFP_KERNEL, "OVER_CURRENT_COUNT=%u",
 			port_dev->over_current_count);
 			port_dev->over_current_count);
@@ -5182,6 +5182,8 @@ static void port_over_current_notify(struct usb_port *port_dev)
 	kfree(envp[1]);
 	kfree(envp[1]);
 exit:
 exit:
 	kfree(envp[0]);
 	kfree(envp[0]);
+exit_path:
+	kfree(port_dev_path);
 }
 }
 
 
 static void port_event(struct usb_hub *hub, int port1)
 static void port_event(struct usb_hub *hub, int port1)