Home Explore Help
Sign In
GfA
/
linux_kernel
5
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

drbd: silence underflow warning in read_in_block()

My static checker warns that "data_size" could be negative and underflow
the limit check.  The code looks suspicious but I don't know if it is a
real bug.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Dan Carpenter 11 years ago
parent
1e39152fea
commit
bf0d6e4a11
2 changed files with 2 additions and 2 deletions
Split View Show Diff Stats
  1. 1 1
      drivers/block/drbd/drbd_receiver.c
  2. 1 1
      include/linux/drbd.h

+ 1 - 1
drivers/block/drbd/drbd_receiver.c
View File 

@@ -1592,7 +1592,7 @@ read_in_block(struct drbd_peer_device *peer_device, u64 id, sector_t sector,
 
 	struct drbd_peer_request *peer_req;
 
 	struct page *page;
 
 	int dgs, ds, err;
 
-	int data_size = pi->size;
 
+	unsigned int data_size = pi->size;
 
 	void *dig_in = peer_device->connection->int_dig_in;
 
 	void *dig_vv = peer_device->connection->int_dig_vv;
 
 	unsigned long *data;

+ 1 - 1
include/linux/drbd.h
View File 

@@ -52,7 +52,7 @@
 
 #endif
 
 
 extern const char *drbd_buildtag(void);
 
-#define REL_VERSION "8.4.3"
 
+#define REL_VERSION "8.4.5"
 
 #define API_VERSION 1
 
 #define PRO_VERSION_MIN 86
 
 #define PRO_VERSION_MAX 101