Browse Source

ath10k: Get rid of superfluous call to pci_disable_msi()

The documentation states that pci_enable_msi_block() returns the number of
requests 'could have been allocated', not 'could allocate'. IOW, MSIs are *not*
enabled if a positive value returned.

kvalo: add commit log based on Alexander's email

Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Alexander Gordeev 11 năm trước cách đây
mục cha
commit
bdcb2c9e2f

+ 0 - 2
drivers/net/wireless/ath/ath10k/pci.c

@@ -2532,8 +2532,6 @@ static int ath10k_pci_init_irq(struct ath10k *ar)
 		ret = pci_enable_msi_block(ar_pci->pdev, ar_pci->num_msi_intrs);
 		ret = pci_enable_msi_block(ar_pci->pdev, ar_pci->num_msi_intrs);
 		if (ret == 0)
 		if (ret == 0)
 			return 0;
 			return 0;
-		if (ret > 0)
-			pci_disable_msi(ar_pci->pdev);
 
 
 		/* fall-through */
 		/* fall-through */
 	}
 	}