浏览代码

IB/ipath: Remove redundant link state checks

This patch removes some redundant checks when the SMA changes the link
state since the same checks are made in the lower level function that
sets the state.

Signed-off-by: Ralph Campbell <ralph.campbell@qlogic.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Ralph Campbell 18 年之前
父节点
当前提交
bda94e32b3
共有 1 个文件被更改,包括 0 次插入6 次删除
  1. 0 6
      drivers/infiniband/hw/ipath/ipath_mad.c

+ 0 - 6
drivers/infiniband/hw/ipath/ipath_mad.c

@@ -402,7 +402,6 @@ static int recv_subn_set_portinfo(struct ib_smp *smp,
 	struct ib_event event;
 	struct ipath_ibdev *dev;
 	struct ipath_devdata *dd;
-	u32 flags;
 	char clientrereg = 0;
 	u16 lid, smlid;
 	u8 lwe;
@@ -541,7 +540,6 @@ static int recv_subn_set_portinfo(struct ib_smp *smp,
 	 * is down or is being set to down.
 	 */
 	state = pip->linkspeed_portstate & 0xF;
-	flags = dd->ipath_flags;
 	lstate = (pip->portphysstate_linkdown >> 4) & 0xF;
 	if (lstate && !(state == IB_PORT_DOWN || state == IB_PORT_NOP))
 		goto err;
@@ -572,13 +570,9 @@ static int recv_subn_set_portinfo(struct ib_smp *smp,
 		ipath_set_linkstate(dd, lstate);
 		break;
 	case IB_PORT_ARMED:
-		if (!(flags & (IPATH_LINKINIT | IPATH_LINKACTIVE)))
-			break;
 		ipath_set_linkstate(dd, IPATH_IB_LINKARM);
 		break;
 	case IB_PORT_ACTIVE:
-		if (!(flags & IPATH_LINKARMED))
-			break;
 		ipath_set_linkstate(dd, IPATH_IB_LINKACTIVE);
 		break;
 	default: