Browse Source

staging: drm/imx: handle framebuffer offsets correctly

We didn't take the pixel format into account, so x-direction
offsets were off by a factor of 2 or 4 for 16bpp and 32bpp
framebuffers.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lucas Stach 11 years ago
parent
commit
bc2b067aab
1 changed files with 2 additions and 1 deletions
  1. 2 1
      drivers/staging/imx-drm/ipuv3-plane.c

+ 2 - 1
drivers/staging/imx-drm/ipuv3-plane.c

@@ -78,7 +78,8 @@ int ipu_plane_set_base(struct ipu_plane *ipu_plane, struct drm_framebuffer *fb,
 	cpmem = ipu_get_cpmem(ipu_plane->ipu_ch);
 	ipu_cpmem_set_stride(cpmem, fb->pitches[0]);
 
-	eba = cma_obj->paddr + fb->offsets[0] + fb->pitches[0] * y + x;
+	eba = cma_obj->paddr + fb->offsets[0] +
+	      fb->pitches[0] * y + (fb->bits_per_pixel >> 3) * x;
 	ipu_cpmem_set_buffer(cpmem, 0, eba);
 	ipu_cpmem_set_buffer(cpmem, 1, eba);