Browse Source

drm/simple_kms_helper: Use drm_mode_get_hv_timing() to populate plane clip rectangle

Use drm_mode_get_hv_timing() to fill out the plane clip rectangle.

Note that this replaces crtc_state->adjusted_mode usage with
crtc_state->mode. The latter is the correct choice since that's the
mode the user provided and it matches the plane crtc coordinates
the user also provided.

Once everyone agrees on this we can move the clip handling into
drm_atomic_helper_check_plane_state().

Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Noralf Trønnes <noralf@tronnes.org>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171123190502.28449-6-ville.syrjala@linux.intel.com
Reviewed-by: Thierry Reding <treding@nvidia.com>
Ville Syrjälä 7 years ago
parent
commit
bb4dd71a75
1 changed files with 3 additions and 2 deletions
  1. 3 2
      drivers/gpu/drm/drm_simple_kms_helper.c

+ 3 - 2
drivers/gpu/drm/drm_simple_kms_helper.c

@@ -100,8 +100,9 @@ static int drm_simple_kms_plane_atomic_check(struct drm_plane *plane,
 	if (!crtc_state->enable)
 	if (!crtc_state->enable)
 		return 0; /* nothing to check when disabling or disabled */
 		return 0; /* nothing to check when disabling or disabled */
 
 
-	clip.x2 = crtc_state->adjusted_mode.hdisplay;
-	clip.y2 = crtc_state->adjusted_mode.vdisplay;
+	if (crtc_state->enable)
+		drm_mode_get_hv_timing(&crtc_state->mode,
+				       &clip.x2, &clip.y2);
 
 
 	ret = drm_atomic_helper_check_plane_state(plane_state, crtc_state,
 	ret = drm_atomic_helper_check_plane_state(plane_state, crtc_state,
 						  &clip,
 						  &clip,