|
@@ -69,12 +69,13 @@
|
|
|
#include <linux/ppdev.h>
|
|
|
#include <linux/mutex.h>
|
|
|
#include <linux/uaccess.h>
|
|
|
+#include <linux/compat.h>
|
|
|
|
|
|
#define PP_VERSION "ppdev: user-space parallel port driver"
|
|
|
#define CHRDEV "ppdev"
|
|
|
|
|
|
struct pp_struct {
|
|
|
- struct pardevice * pdev;
|
|
|
+ struct pardevice *pdev;
|
|
|
wait_queue_head_t irq_wait;
|
|
|
atomic_t irqc;
|
|
|
unsigned int flags;
|
|
@@ -98,18 +99,26 @@ struct pp_struct {
|
|
|
#define ROUND_UP(x,y) (((x)+(y)-1)/(y))
|
|
|
|
|
|
static DEFINE_MUTEX(pp_do_mutex);
|
|
|
-static inline void pp_enable_irq (struct pp_struct *pp)
|
|
|
+
|
|
|
+/* define fixed sized ioctl cmd for y2038 migration */
|
|
|
+#define PPGETTIME32 _IOR(PP_IOCTL, 0x95, s32[2])
|
|
|
+#define PPSETTIME32 _IOW(PP_IOCTL, 0x96, s32[2])
|
|
|
+#define PPGETTIME64 _IOR(PP_IOCTL, 0x95, s64[2])
|
|
|
+#define PPSETTIME64 _IOW(PP_IOCTL, 0x96, s64[2])
|
|
|
+
|
|
|
+static inline void pp_enable_irq(struct pp_struct *pp)
|
|
|
{
|
|
|
struct parport *port = pp->pdev->port;
|
|
|
- port->ops->enable_irq (port);
|
|
|
+
|
|
|
+ port->ops->enable_irq(port);
|
|
|
}
|
|
|
|
|
|
-static ssize_t pp_read (struct file * file, char __user * buf, size_t count,
|
|
|
- loff_t * ppos)
|
|
|
+static ssize_t pp_read(struct file *file, char __user *buf, size_t count,
|
|
|
+ loff_t *ppos)
|
|
|
{
|
|
|
unsigned int minor = iminor(file_inode(file));
|
|
|
struct pp_struct *pp = file->private_data;
|
|
|
- char * kbuffer;
|
|
|
+ char *kbuffer;
|
|
|
ssize_t bytes_read = 0;
|
|
|
struct parport *pport;
|
|
|
int mode;
|
|
@@ -125,16 +134,15 @@ static ssize_t pp_read (struct file * file, char __user * buf, size_t count,
|
|
|
return 0;
|
|
|
|
|
|
kbuffer = kmalloc(min_t(size_t, count, PP_BUFFER_SIZE), GFP_KERNEL);
|
|
|
- if (!kbuffer) {
|
|
|
+ if (!kbuffer)
|
|
|
return -ENOMEM;
|
|
|
- }
|
|
|
pport = pp->pdev->port;
|
|
|
mode = pport->ieee1284.mode & ~(IEEE1284_DEVICEID | IEEE1284_ADDR);
|
|
|
|
|
|
- parport_set_timeout (pp->pdev,
|
|
|
- (file->f_flags & O_NONBLOCK) ?
|
|
|
- PARPORT_INACTIVITY_O_NONBLOCK :
|
|
|
- pp->default_inactivity);
|
|
|
+ parport_set_timeout(pp->pdev,
|
|
|
+ (file->f_flags & O_NONBLOCK) ?
|
|
|
+ PARPORT_INACTIVITY_O_NONBLOCK :
|
|
|
+ pp->default_inactivity);
|
|
|
|
|
|
while (bytes_read == 0) {
|
|
|
ssize_t need = min_t(unsigned long, count, PP_BUFFER_SIZE);
|
|
@@ -144,20 +152,17 @@ static ssize_t pp_read (struct file * file, char __user * buf, size_t count,
|
|
|
int flags = 0;
|
|
|
size_t (*fn)(struct parport *, void *, size_t, int);
|
|
|
|
|
|
- if (pp->flags & PP_W91284PIC) {
|
|
|
+ if (pp->flags & PP_W91284PIC)
|
|
|
flags |= PARPORT_W91284PIC;
|
|
|
- }
|
|
|
- if (pp->flags & PP_FASTREAD) {
|
|
|
+ if (pp->flags & PP_FASTREAD)
|
|
|
flags |= PARPORT_EPP_FAST;
|
|
|
- }
|
|
|
- if (pport->ieee1284.mode & IEEE1284_ADDR) {
|
|
|
+ if (pport->ieee1284.mode & IEEE1284_ADDR)
|
|
|
fn = pport->ops->epp_read_addr;
|
|
|
- } else {
|
|
|
+ else
|
|
|
fn = pport->ops->epp_read_data;
|
|
|
- }
|
|
|
bytes_read = (*fn)(pport, kbuffer, need, flags);
|
|
|
} else {
|
|
|
- bytes_read = parport_read (pport, kbuffer, need);
|
|
|
+ bytes_read = parport_read(pport, kbuffer, need);
|
|
|
}
|
|
|
|
|
|
if (bytes_read != 0)
|
|
@@ -168,7 +173,7 @@ static ssize_t pp_read (struct file * file, char __user * buf, size_t count,
|
|
|
break;
|
|
|
}
|
|
|
|
|
|
- if (signal_pending (current)) {
|
|
|
+ if (signal_pending(current)) {
|
|
|
bytes_read = -ERESTARTSYS;
|
|
|
break;
|
|
|
}
|
|
@@ -176,22 +181,22 @@ static ssize_t pp_read (struct file * file, char __user * buf, size_t count,
|
|
|
cond_resched();
|
|
|
}
|
|
|
|
|
|
- parport_set_timeout (pp->pdev, pp->default_inactivity);
|
|
|
+ parport_set_timeout(pp->pdev, pp->default_inactivity);
|
|
|
|
|
|
- if (bytes_read > 0 && copy_to_user (buf, kbuffer, bytes_read))
|
|
|
+ if (bytes_read > 0 && copy_to_user(buf, kbuffer, bytes_read))
|
|
|
bytes_read = -EFAULT;
|
|
|
|
|
|
- kfree (kbuffer);
|
|
|
- pp_enable_irq (pp);
|
|
|
+ kfree(kbuffer);
|
|
|
+ pp_enable_irq(pp);
|
|
|
return bytes_read;
|
|
|
}
|
|
|
|
|
|
-static ssize_t pp_write (struct file * file, const char __user * buf,
|
|
|
- size_t count, loff_t * ppos)
|
|
|
+static ssize_t pp_write(struct file *file, const char __user *buf,
|
|
|
+ size_t count, loff_t *ppos)
|
|
|
{
|
|
|
unsigned int minor = iminor(file_inode(file));
|
|
|
struct pp_struct *pp = file->private_data;
|
|
|
- char * kbuffer;
|
|
|
+ char *kbuffer;
|
|
|
ssize_t bytes_written = 0;
|
|
|
ssize_t wrote;
|
|
|
int mode;
|
|
@@ -204,21 +209,21 @@ static ssize_t pp_write (struct file * file, const char __user * buf,
|
|
|
}
|
|
|
|
|
|
kbuffer = kmalloc(min_t(size_t, count, PP_BUFFER_SIZE), GFP_KERNEL);
|
|
|
- if (!kbuffer) {
|
|
|
+ if (!kbuffer)
|
|
|
return -ENOMEM;
|
|
|
- }
|
|
|
+
|
|
|
pport = pp->pdev->port;
|
|
|
mode = pport->ieee1284.mode & ~(IEEE1284_DEVICEID | IEEE1284_ADDR);
|
|
|
|
|
|
- parport_set_timeout (pp->pdev,
|
|
|
- (file->f_flags & O_NONBLOCK) ?
|
|
|
- PARPORT_INACTIVITY_O_NONBLOCK :
|
|
|
- pp->default_inactivity);
|
|
|
+ parport_set_timeout(pp->pdev,
|
|
|
+ (file->f_flags & O_NONBLOCK) ?
|
|
|
+ PARPORT_INACTIVITY_O_NONBLOCK :
|
|
|
+ pp->default_inactivity);
|
|
|
|
|
|
while (bytes_written < count) {
|
|
|
ssize_t n = min_t(unsigned long, count - bytes_written, PP_BUFFER_SIZE);
|
|
|
|
|
|
- if (copy_from_user (kbuffer, buf + bytes_written, n)) {
|
|
|
+ if (copy_from_user(kbuffer, buf + bytes_written, n)) {
|
|
|
bytes_written = -EFAULT;
|
|
|
break;
|
|
|
}
|
|
@@ -226,20 +231,19 @@ static ssize_t pp_write (struct file * file, const char __user * buf,
|
|
|
if ((pp->flags & PP_FASTWRITE) && (mode == IEEE1284_MODE_EPP)) {
|
|
|
/* do a fast EPP write */
|
|
|
if (pport->ieee1284.mode & IEEE1284_ADDR) {
|
|
|
- wrote = pport->ops->epp_write_addr (pport,
|
|
|
+ wrote = pport->ops->epp_write_addr(pport,
|
|
|
kbuffer, n, PARPORT_EPP_FAST);
|
|
|
} else {
|
|
|
- wrote = pport->ops->epp_write_data (pport,
|
|
|
+ wrote = pport->ops->epp_write_data(pport,
|
|
|
kbuffer, n, PARPORT_EPP_FAST);
|
|
|
}
|
|
|
} else {
|
|
|
- wrote = parport_write (pp->pdev->port, kbuffer, n);
|
|
|
+ wrote = parport_write(pp->pdev->port, kbuffer, n);
|
|
|
}
|
|
|
|
|
|
if (wrote <= 0) {
|
|
|
- if (!bytes_written) {
|
|
|
+ if (!bytes_written)
|
|
|
bytes_written = wrote;
|
|
|
- }
|
|
|
break;
|
|
|
}
|
|
|
|
|
@@ -251,67 +255,69 @@ static ssize_t pp_write (struct file * file, const char __user * buf,
|
|
|
break;
|
|
|
}
|
|
|
|
|
|
- if (signal_pending (current))
|
|
|
+ if (signal_pending(current))
|
|
|
break;
|
|
|
|
|
|
cond_resched();
|
|
|
}
|
|
|
|
|
|
- parport_set_timeout (pp->pdev, pp->default_inactivity);
|
|
|
+ parport_set_timeout(pp->pdev, pp->default_inactivity);
|
|
|
|
|
|
- kfree (kbuffer);
|
|
|
- pp_enable_irq (pp);
|
|
|
+ kfree(kbuffer);
|
|
|
+ pp_enable_irq(pp);
|
|
|
return bytes_written;
|
|
|
}
|
|
|
|
|
|
-static void pp_irq (void *private)
|
|
|
+static void pp_irq(void *private)
|
|
|
{
|
|
|
struct pp_struct *pp = private;
|
|
|
|
|
|
if (pp->irqresponse) {
|
|
|
- parport_write_control (pp->pdev->port, pp->irqctl);
|
|
|
+ parport_write_control(pp->pdev->port, pp->irqctl);
|
|
|
pp->irqresponse = 0;
|
|
|
}
|
|
|
|
|
|
- atomic_inc (&pp->irqc);
|
|
|
- wake_up_interruptible (&pp->irq_wait);
|
|
|
+ atomic_inc(&pp->irqc);
|
|
|
+ wake_up_interruptible(&pp->irq_wait);
|
|
|
}
|
|
|
|
|
|
-static int register_device (int minor, struct pp_struct *pp)
|
|
|
+static int register_device(int minor, struct pp_struct *pp)
|
|
|
{
|
|
|
struct parport *port;
|
|
|
- struct pardevice * pdev = NULL;
|
|
|
+ struct pardevice *pdev = NULL;
|
|
|
char *name;
|
|
|
- int fl;
|
|
|
+ struct pardev_cb ppdev_cb;
|
|
|
|
|
|
name = kasprintf(GFP_KERNEL, CHRDEV "%x", minor);
|
|
|
if (name == NULL)
|
|
|
return -ENOMEM;
|
|
|
|
|
|
- port = parport_find_number (minor);
|
|
|
+ port = parport_find_number(minor);
|
|
|
if (!port) {
|
|
|
- printk (KERN_WARNING "%s: no associated port!\n", name);
|
|
|
- kfree (name);
|
|
|
+ printk(KERN_WARNING "%s: no associated port!\n", name);
|
|
|
+ kfree(name);
|
|
|
return -ENXIO;
|
|
|
}
|
|
|
|
|
|
- fl = (pp->flags & PP_EXCL) ? PARPORT_FLAG_EXCL : 0;
|
|
|
- pdev = parport_register_device (port, name, NULL,
|
|
|
- NULL, pp_irq, fl, pp);
|
|
|
- parport_put_port (port);
|
|
|
+ memset(&ppdev_cb, 0, sizeof(ppdev_cb));
|
|
|
+ ppdev_cb.irq_func = pp_irq;
|
|
|
+ ppdev_cb.flags = (pp->flags & PP_EXCL) ? PARPORT_FLAG_EXCL : 0;
|
|
|
+ ppdev_cb.private = pp;
|
|
|
+ pdev = parport_register_dev_model(port, name, &ppdev_cb, minor);
|
|
|
+ parport_put_port(port);
|
|
|
|
|
|
if (!pdev) {
|
|
|
- printk (KERN_WARNING "%s: failed to register device!\n", name);
|
|
|
- kfree (name);
|
|
|
+ printk(KERN_WARNING "%s: failed to register device!\n", name);
|
|
|
+ kfree(name);
|
|
|
return -ENXIO;
|
|
|
}
|
|
|
|
|
|
pp->pdev = pdev;
|
|
|
- pr_debug("%s: registered pardevice\n", name);
|
|
|
+ dev_dbg(&pdev->dev, "registered pardevice\n");
|
|
|
return 0;
|
|
|
}
|
|
|
|
|
|
-static enum ieee1284_phase init_phase (int mode)
|
|
|
+static enum ieee1284_phase init_phase(int mode)
|
|
|
{
|
|
|
switch (mode & ~(IEEE1284_DEVICEID
|
|
|
| IEEE1284_ADDR)) {
|
|
@@ -322,11 +328,27 @@ static enum ieee1284_phase init_phase (int mode)
|
|
|
return IEEE1284_PH_FWD_IDLE;
|
|
|
}
|
|
|
|
|
|
+static int pp_set_timeout(struct pardevice *pdev, long tv_sec, int tv_usec)
|
|
|
+{
|
|
|
+ long to_jiffies;
|
|
|
+
|
|
|
+ if ((tv_sec < 0) || (tv_usec < 0))
|
|
|
+ return -EINVAL;
|
|
|
+
|
|
|
+ to_jiffies = usecs_to_jiffies(tv_usec);
|
|
|
+ to_jiffies += tv_sec * HZ;
|
|
|
+ if (to_jiffies <= 0)
|
|
|
+ return -EINVAL;
|
|
|
+
|
|
|
+ pdev->timeout = to_jiffies;
|
|
|
+ return 0;
|
|
|
+}
|
|
|
+
|
|
|
static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
|
|
|
{
|
|
|
unsigned int minor = iminor(file_inode(file));
|
|
|
struct pp_struct *pp = file->private_data;
|
|
|
- struct parport * port;
|
|
|
+ struct parport *port;
|
|
|
void __user *argp = (void __user *)arg;
|
|
|
|
|
|
/* First handle the cases that don't take arguments. */
|
|
@@ -337,19 +359,19 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
|
|
|
int ret;
|
|
|
|
|
|
if (pp->flags & PP_CLAIMED) {
|
|
|
- pr_debug(CHRDEV "%x: you've already got it!\n", minor);
|
|
|
+ dev_dbg(&pp->pdev->dev, "you've already got it!\n");
|
|
|
return -EINVAL;
|
|
|
}
|
|
|
|
|
|
/* Deferred device registration. */
|
|
|
if (!pp->pdev) {
|
|
|
- int err = register_device (minor, pp);
|
|
|
- if (err) {
|
|
|
+ int err = register_device(minor, pp);
|
|
|
+
|
|
|
+ if (err)
|
|
|
return err;
|
|
|
- }
|
|
|
}
|
|
|
|
|
|
- ret = parport_claim_or_block (pp->pdev);
|
|
|
+ ret = parport_claim_or_block(pp->pdev);
|
|
|
if (ret < 0)
|
|
|
return ret;
|
|
|
|
|
@@ -357,7 +379,7 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
|
|
|
|
|
|
/* For interrupt-reporting to work, we need to be
|
|
|
* informed of each interrupt. */
|
|
|
- pp_enable_irq (pp);
|
|
|
+ pp_enable_irq(pp);
|
|
|
|
|
|
/* We may need to fix up the state machine. */
|
|
|
info = &pp->pdev->port->ieee1284;
|
|
@@ -365,15 +387,15 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
|
|
|
pp->saved_state.phase = info->phase;
|
|
|
info->mode = pp->state.mode;
|
|
|
info->phase = pp->state.phase;
|
|
|
- pp->default_inactivity = parport_set_timeout (pp->pdev, 0);
|
|
|
- parport_set_timeout (pp->pdev, pp->default_inactivity);
|
|
|
+ pp->default_inactivity = parport_set_timeout(pp->pdev, 0);
|
|
|
+ parport_set_timeout(pp->pdev, pp->default_inactivity);
|
|
|
|
|
|
return 0;
|
|
|
}
|
|
|
case PPEXCL:
|
|
|
if (pp->pdev) {
|
|
|
- pr_debug(CHRDEV "%x: too late for PPEXCL; "
|
|
|
- "already registered\n", minor);
|
|
|
+ dev_dbg(&pp->pdev->dev,
|
|
|
+ "too late for PPEXCL; already registered\n");
|
|
|
if (pp->flags & PP_EXCL)
|
|
|
/* But it's not really an error. */
|
|
|
return 0;
|
|
@@ -388,11 +410,12 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
|
|
|
case PPSETMODE:
|
|
|
{
|
|
|
int mode;
|
|
|
- if (copy_from_user (&mode, argp, sizeof (mode)))
|
|
|
+
|
|
|
+ if (copy_from_user(&mode, argp, sizeof(mode)))
|
|
|
return -EFAULT;
|
|
|
/* FIXME: validate mode */
|
|
|
pp->state.mode = mode;
|
|
|
- pp->state.phase = init_phase (mode);
|
|
|
+ pp->state.phase = init_phase(mode);
|
|
|
|
|
|
if (pp->flags & PP_CLAIMED) {
|
|
|
pp->pdev->port->ieee1284.mode = mode;
|
|
@@ -405,28 +428,27 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
|
|
|
{
|
|
|
int mode;
|
|
|
|
|
|
- if (pp->flags & PP_CLAIMED) {
|
|
|
+ if (pp->flags & PP_CLAIMED)
|
|
|
mode = pp->pdev->port->ieee1284.mode;
|
|
|
- } else {
|
|
|
+ else
|
|
|
mode = pp->state.mode;
|
|
|
- }
|
|
|
- if (copy_to_user (argp, &mode, sizeof (mode))) {
|
|
|
+
|
|
|
+ if (copy_to_user(argp, &mode, sizeof(mode)))
|
|
|
return -EFAULT;
|
|
|
- }
|
|
|
return 0;
|
|
|
}
|
|
|
case PPSETPHASE:
|
|
|
{
|
|
|
int phase;
|
|
|
- if (copy_from_user (&phase, argp, sizeof (phase))) {
|
|
|
+
|
|
|
+ if (copy_from_user(&phase, argp, sizeof(phase)))
|
|
|
return -EFAULT;
|
|
|
- }
|
|
|
+
|
|
|
/* FIXME: validate phase */
|
|
|
pp->state.phase = phase;
|
|
|
|
|
|
- if (pp->flags & PP_CLAIMED) {
|
|
|
+ if (pp->flags & PP_CLAIMED)
|
|
|
pp->pdev->port->ieee1284.phase = phase;
|
|
|
- }
|
|
|
|
|
|
return 0;
|
|
|
}
|
|
@@ -434,38 +456,34 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
|
|
|
{
|
|
|
int phase;
|
|
|
|
|
|
- if (pp->flags & PP_CLAIMED) {
|
|
|
+ if (pp->flags & PP_CLAIMED)
|
|
|
phase = pp->pdev->port->ieee1284.phase;
|
|
|
- } else {
|
|
|
+ else
|
|
|
phase = pp->state.phase;
|
|
|
- }
|
|
|
- if (copy_to_user (argp, &phase, sizeof (phase))) {
|
|
|
+ if (copy_to_user(argp, &phase, sizeof(phase)))
|
|
|
return -EFAULT;
|
|
|
- }
|
|
|
return 0;
|
|
|
}
|
|
|
case PPGETMODES:
|
|
|
{
|
|
|
unsigned int modes;
|
|
|
|
|
|
- port = parport_find_number (minor);
|
|
|
+ port = parport_find_number(minor);
|
|
|
if (!port)
|
|
|
return -ENODEV;
|
|
|
|
|
|
modes = port->modes;
|
|
|
parport_put_port(port);
|
|
|
- if (copy_to_user (argp, &modes, sizeof (modes))) {
|
|
|
+ if (copy_to_user(argp, &modes, sizeof(modes)))
|
|
|
return -EFAULT;
|
|
|
- }
|
|
|
return 0;
|
|
|
}
|
|
|
case PPSETFLAGS:
|
|
|
{
|
|
|
int uflags;
|
|
|
|
|
|
- if (copy_from_user (&uflags, argp, sizeof (uflags))) {
|
|
|
+ if (copy_from_user(&uflags, argp, sizeof(uflags)))
|
|
|
return -EFAULT;
|
|
|
- }
|
|
|
pp->flags &= ~PP_FLAGMASK;
|
|
|
pp->flags |= (uflags & PP_FLAGMASK);
|
|
|
return 0;
|
|
@@ -475,9 +493,8 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
|
|
|
int uflags;
|
|
|
|
|
|
uflags = pp->flags & PP_FLAGMASK;
|
|
|
- if (copy_to_user (argp, &uflags, sizeof (uflags))) {
|
|
|
+ if (copy_to_user(argp, &uflags, sizeof(uflags)))
|
|
|
return -EFAULT;
|
|
|
- }
|
|
|
return 0;
|
|
|
}
|
|
|
} /* end switch() */
|
|
@@ -495,27 +512,28 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
|
|
|
unsigned char reg;
|
|
|
unsigned char mask;
|
|
|
int mode;
|
|
|
+ s32 time32[2];
|
|
|
+ s64 time64[2];
|
|
|
+ struct timespec64 ts;
|
|
|
int ret;
|
|
|
- struct timeval par_timeout;
|
|
|
- long to_jiffies;
|
|
|
|
|
|
case PPRSTATUS:
|
|
|
- reg = parport_read_status (port);
|
|
|
- if (copy_to_user (argp, ®, sizeof (reg)))
|
|
|
+ reg = parport_read_status(port);
|
|
|
+ if (copy_to_user(argp, ®, sizeof(reg)))
|
|
|
return -EFAULT;
|
|
|
return 0;
|
|
|
case PPRDATA:
|
|
|
- reg = parport_read_data (port);
|
|
|
- if (copy_to_user (argp, ®, sizeof (reg)))
|
|
|
+ reg = parport_read_data(port);
|
|
|
+ if (copy_to_user(argp, ®, sizeof(reg)))
|
|
|
return -EFAULT;
|
|
|
return 0;
|
|
|
case PPRCONTROL:
|
|
|
- reg = parport_read_control (port);
|
|
|
- if (copy_to_user (argp, ®, sizeof (reg)))
|
|
|
+ reg = parport_read_control(port);
|
|
|
+ if (copy_to_user(argp, ®, sizeof(reg)))
|
|
|
return -EFAULT;
|
|
|
return 0;
|
|
|
case PPYIELD:
|
|
|
- parport_yield_blocking (pp->pdev);
|
|
|
+ parport_yield_blocking(pp->pdev);
|
|
|
return 0;
|
|
|
|
|
|
case PPRELEASE:
|
|
@@ -525,45 +543,45 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
|
|
|
pp->state.phase = info->phase;
|
|
|
info->mode = pp->saved_state.mode;
|
|
|
info->phase = pp->saved_state.phase;
|
|
|
- parport_release (pp->pdev);
|
|
|
+ parport_release(pp->pdev);
|
|
|
pp->flags &= ~PP_CLAIMED;
|
|
|
return 0;
|
|
|
|
|
|
case PPWCONTROL:
|
|
|
- if (copy_from_user (®, argp, sizeof (reg)))
|
|
|
+ if (copy_from_user(®, argp, sizeof(reg)))
|
|
|
return -EFAULT;
|
|
|
- parport_write_control (port, reg);
|
|
|
+ parport_write_control(port, reg);
|
|
|
return 0;
|
|
|
|
|
|
case PPWDATA:
|
|
|
- if (copy_from_user (®, argp, sizeof (reg)))
|
|
|
+ if (copy_from_user(®, argp, sizeof(reg)))
|
|
|
return -EFAULT;
|
|
|
- parport_write_data (port, reg);
|
|
|
+ parport_write_data(port, reg);
|
|
|
return 0;
|
|
|
|
|
|
case PPFCONTROL:
|
|
|
- if (copy_from_user (&mask, argp,
|
|
|
- sizeof (mask)))
|
|
|
+ if (copy_from_user(&mask, argp,
|
|
|
+ sizeof(mask)))
|
|
|
return -EFAULT;
|
|
|
- if (copy_from_user (®, 1 + (unsigned char __user *) arg,
|
|
|
- sizeof (reg)))
|
|
|
+ if (copy_from_user(®, 1 + (unsigned char __user *) arg,
|
|
|
+ sizeof(reg)))
|
|
|
return -EFAULT;
|
|
|
- parport_frob_control (port, mask, reg);
|
|
|
+ parport_frob_control(port, mask, reg);
|
|
|
return 0;
|
|
|
|
|
|
case PPDATADIR:
|
|
|
- if (copy_from_user (&mode, argp, sizeof (mode)))
|
|
|
+ if (copy_from_user(&mode, argp, sizeof(mode)))
|
|
|
return -EFAULT;
|
|
|
if (mode)
|
|
|
- port->ops->data_reverse (port);
|
|
|
+ port->ops->data_reverse(port);
|
|
|
else
|
|
|
- port->ops->data_forward (port);
|
|
|
+ port->ops->data_forward(port);
|
|
|
return 0;
|
|
|
|
|
|
case PPNEGOT:
|
|
|
- if (copy_from_user (&mode, argp, sizeof (mode)))
|
|
|
+ if (copy_from_user(&mode, argp, sizeof(mode)))
|
|
|
return -EFAULT;
|
|
|
- switch ((ret = parport_negotiate (port, mode))) {
|
|
|
+ switch ((ret = parport_negotiate(port, mode))) {
|
|
|
case 0: break;
|
|
|
case -1: /* handshake failed, peripheral not IEEE 1284 */
|
|
|
ret = -EIO;
|
|
@@ -572,11 +590,11 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
|
|
|
ret = -ENXIO;
|
|
|
break;
|
|
|
}
|
|
|
- pp_enable_irq (pp);
|
|
|
+ pp_enable_irq(pp);
|
|
|
return ret;
|
|
|
|
|
|
case PPWCTLONIRQ:
|
|
|
- if (copy_from_user (®, argp, sizeof (reg)))
|
|
|
+ if (copy_from_user(®, argp, sizeof(reg)))
|
|
|
return -EFAULT;
|
|
|
|
|
|
/* Remember what to set the control lines to, for next
|
|
@@ -586,39 +604,50 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
|
|
|
return 0;
|
|
|
|
|
|
case PPCLRIRQ:
|
|
|
- ret = atomic_read (&pp->irqc);
|
|
|
- if (copy_to_user (argp, &ret, sizeof (ret)))
|
|
|
+ ret = atomic_read(&pp->irqc);
|
|
|
+ if (copy_to_user(argp, &ret, sizeof(ret)))
|
|
|
return -EFAULT;
|
|
|
- atomic_sub (ret, &pp->irqc);
|
|
|
+ atomic_sub(ret, &pp->irqc);
|
|
|
return 0;
|
|
|
|
|
|
- case PPSETTIME:
|
|
|
- if (copy_from_user (&par_timeout, argp, sizeof(struct timeval))) {
|
|
|
+ case PPSETTIME32:
|
|
|
+ if (copy_from_user(time32, argp, sizeof(time32)))
|
|
|
return -EFAULT;
|
|
|
- }
|
|
|
- /* Convert to jiffies, place in pp->pdev->timeout */
|
|
|
- if ((par_timeout.tv_sec < 0) || (par_timeout.tv_usec < 0)) {
|
|
|
- return -EINVAL;
|
|
|
- }
|
|
|
- to_jiffies = ROUND_UP(par_timeout.tv_usec, 1000000/HZ);
|
|
|
- to_jiffies += par_timeout.tv_sec * (long)HZ;
|
|
|
- if (to_jiffies <= 0) {
|
|
|
+
|
|
|
+ return pp_set_timeout(pp->pdev, time32[0], time32[1]);
|
|
|
+
|
|
|
+ case PPSETTIME64:
|
|
|
+ if (copy_from_user(time64, argp, sizeof(time64)))
|
|
|
+ return -EFAULT;
|
|
|
+
|
|
|
+ return pp_set_timeout(pp->pdev, time64[0], time64[1]);
|
|
|
+
|
|
|
+ case PPGETTIME32:
|
|
|
+ jiffies_to_timespec64(pp->pdev->timeout, &ts);
|
|
|
+ time32[0] = ts.tv_sec;
|
|
|
+ time32[1] = ts.tv_nsec / NSEC_PER_USEC;
|
|
|
+ if ((time32[0] < 0) || (time32[1] < 0))
|
|
|
return -EINVAL;
|
|
|
- }
|
|
|
- pp->pdev->timeout = to_jiffies;
|
|
|
+
|
|
|
+ if (copy_to_user(argp, time32, sizeof(time32)))
|
|
|
+ return -EFAULT;
|
|
|
+
|
|
|
return 0;
|
|
|
|
|
|
- case PPGETTIME:
|
|
|
- to_jiffies = pp->pdev->timeout;
|
|
|
- memset(&par_timeout, 0, sizeof(par_timeout));
|
|
|
- par_timeout.tv_sec = to_jiffies / HZ;
|
|
|
- par_timeout.tv_usec = (to_jiffies % (long)HZ) * (1000000/HZ);
|
|
|
- if (copy_to_user (argp, &par_timeout, sizeof(struct timeval)))
|
|
|
+ case PPGETTIME64:
|
|
|
+ jiffies_to_timespec64(pp->pdev->timeout, &ts);
|
|
|
+ time64[0] = ts.tv_sec;
|
|
|
+ time64[1] = ts.tv_nsec / NSEC_PER_USEC;
|
|
|
+ if ((time64[0] < 0) || (time64[1] < 0))
|
|
|
+ return -EINVAL;
|
|
|
+
|
|
|
+ if (copy_to_user(argp, time64, sizeof(time64)))
|
|
|
return -EFAULT;
|
|
|
+
|
|
|
return 0;
|
|
|
|
|
|
default:
|
|
|
- pr_debug(CHRDEV "%x: What? (cmd=0x%x)\n", minor, cmd);
|
|
|
+ dev_dbg(&pp->pdev->dev, "What? (cmd=0x%x)\n", cmd);
|
|
|
return -EINVAL;
|
|
|
}
|
|
|
|
|
@@ -629,13 +658,22 @@ static int pp_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
|
|
|
static long pp_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
|
|
|
{
|
|
|
long ret;
|
|
|
+
|
|
|
mutex_lock(&pp_do_mutex);
|
|
|
ret = pp_do_ioctl(file, cmd, arg);
|
|
|
mutex_unlock(&pp_do_mutex);
|
|
|
return ret;
|
|
|
}
|
|
|
|
|
|
-static int pp_open (struct inode * inode, struct file * file)
|
|
|
+#ifdef CONFIG_COMPAT
|
|
|
+static long pp_compat_ioctl(struct file *file, unsigned int cmd,
|
|
|
+ unsigned long arg)
|
|
|
+{
|
|
|
+ return pp_ioctl(file, cmd, (unsigned long)compat_ptr(arg));
|
|
|
+}
|
|
|
+#endif
|
|
|
+
|
|
|
+static int pp_open(struct inode *inode, struct file *file)
|
|
|
{
|
|
|
unsigned int minor = iminor(inode);
|
|
|
struct pp_struct *pp;
|
|
@@ -643,16 +681,16 @@ static int pp_open (struct inode * inode, struct file * file)
|
|
|
if (minor >= PARPORT_MAX)
|
|
|
return -ENXIO;
|
|
|
|
|
|
- pp = kmalloc (sizeof (struct pp_struct), GFP_KERNEL);
|
|
|
+ pp = kmalloc(sizeof(struct pp_struct), GFP_KERNEL);
|
|
|
if (!pp)
|
|
|
return -ENOMEM;
|
|
|
|
|
|
pp->state.mode = IEEE1284_MODE_COMPAT;
|
|
|
- pp->state.phase = init_phase (pp->state.mode);
|
|
|
+ pp->state.phase = init_phase(pp->state.mode);
|
|
|
pp->flags = 0;
|
|
|
pp->irqresponse = 0;
|
|
|
- atomic_set (&pp->irqc, 0);
|
|
|
- init_waitqueue_head (&pp->irq_wait);
|
|
|
+ atomic_set(&pp->irqc, 0);
|
|
|
+ init_waitqueue_head(&pp->irq_wait);
|
|
|
|
|
|
/* Defer the actual device registration until the first claim.
|
|
|
* That way, we know whether or not the driver wants to have
|
|
@@ -664,7 +702,7 @@ static int pp_open (struct inode * inode, struct file * file)
|
|
|
return 0;
|
|
|
}
|
|
|
|
|
|
-static int pp_release (struct inode * inode, struct file * file)
|
|
|
+static int pp_release(struct inode *inode, struct file *file)
|
|
|
{
|
|
|
unsigned int minor = iminor(inode);
|
|
|
struct pp_struct *pp = file->private_data;
|
|
@@ -673,10 +711,10 @@ static int pp_release (struct inode * inode, struct file * file)
|
|
|
compat_negot = 0;
|
|
|
if (!(pp->flags & PP_CLAIMED) && pp->pdev &&
|
|
|
(pp->state.mode != IEEE1284_MODE_COMPAT)) {
|
|
|
- struct ieee1284_info *info;
|
|
|
+ struct ieee1284_info *info;
|
|
|
|
|
|
/* parport released, but not in compatibility mode */
|
|
|
- parport_claim_or_block (pp->pdev);
|
|
|
+ parport_claim_or_block(pp->pdev);
|
|
|
pp->flags |= PP_CLAIMED;
|
|
|
info = &pp->pdev->port->ieee1284;
|
|
|
pp->saved_state.mode = info->mode;
|
|
@@ -689,9 +727,9 @@ static int pp_release (struct inode * inode, struct file * file)
|
|
|
compat_negot = 2;
|
|
|
}
|
|
|
if (compat_negot) {
|
|
|
- parport_negotiate (pp->pdev->port, IEEE1284_MODE_COMPAT);
|
|
|
- pr_debug(CHRDEV "%x: negotiated back to compatibility "
|
|
|
- "mode because user-space forgot\n", minor);
|
|
|
+ parport_negotiate(pp->pdev->port, IEEE1284_MODE_COMPAT);
|
|
|
+ dev_dbg(&pp->pdev->dev,
|
|
|
+ "negotiated back to compatibility mode because user-space forgot\n");
|
|
|
}
|
|
|
|
|
|
if (pp->flags & PP_CLAIMED) {
|
|
@@ -702,7 +740,7 @@ static int pp_release (struct inode * inode, struct file * file)
|
|
|
pp->state.phase = info->phase;
|
|
|
info->mode = pp->saved_state.mode;
|
|
|
info->phase = pp->saved_state.phase;
|
|
|
- parport_release (pp->pdev);
|
|
|
+ parport_release(pp->pdev);
|
|
|
if (compat_negot != 1) {
|
|
|
pr_debug(CHRDEV "%x: released pardevice "
|
|
|
"because user-space forgot\n", minor);
|
|
@@ -711,25 +749,26 @@ static int pp_release (struct inode * inode, struct file * file)
|
|
|
|
|
|
if (pp->pdev) {
|
|
|
const char *name = pp->pdev->name;
|
|
|
- parport_unregister_device (pp->pdev);
|
|
|
- kfree (name);
|
|
|
+
|
|
|
+ parport_unregister_device(pp->pdev);
|
|
|
+ kfree(name);
|
|
|
pp->pdev = NULL;
|
|
|
pr_debug(CHRDEV "%x: unregistered pardevice\n", minor);
|
|
|
}
|
|
|
|
|
|
- kfree (pp);
|
|
|
+ kfree(pp);
|
|
|
|
|
|
return 0;
|
|
|
}
|
|
|
|
|
|
/* No kernel lock held - fine */
|
|
|
-static unsigned int pp_poll (struct file * file, poll_table * wait)
|
|
|
+static unsigned int pp_poll(struct file *file, poll_table *wait)
|
|
|
{
|
|
|
struct pp_struct *pp = file->private_data;
|
|
|
unsigned int mask = 0;
|
|
|
|
|
|
- poll_wait (file, &pp->irq_wait, wait);
|
|
|
- if (atomic_read (&pp->irqc))
|
|
|
+ poll_wait(file, &pp->irq_wait, wait);
|
|
|
+ if (atomic_read(&pp->irqc))
|
|
|
mask |= POLLIN | POLLRDNORM;
|
|
|
|
|
|
return mask;
|
|
@@ -744,6 +783,9 @@ static const struct file_operations pp_fops = {
|
|
|
.write = pp_write,
|
|
|
.poll = pp_poll,
|
|
|
.unlocked_ioctl = pp_ioctl,
|
|
|
+#ifdef CONFIG_COMPAT
|
|
|
+ .compat_ioctl = pp_compat_ioctl,
|
|
|
+#endif
|
|
|
.open = pp_open,
|
|
|
.release = pp_release,
|
|
|
};
|
|
@@ -759,19 +801,32 @@ static void pp_detach(struct parport *port)
|
|
|
device_destroy(ppdev_class, MKDEV(PP_MAJOR, port->number));
|
|
|
}
|
|
|
|
|
|
+static int pp_probe(struct pardevice *par_dev)
|
|
|
+{
|
|
|
+ struct device_driver *drv = par_dev->dev.driver;
|
|
|
+ int len = strlen(drv->name);
|
|
|
+
|
|
|
+ if (strncmp(par_dev->name, drv->name, len))
|
|
|
+ return -ENODEV;
|
|
|
+
|
|
|
+ return 0;
|
|
|
+}
|
|
|
+
|
|
|
static struct parport_driver pp_driver = {
|
|
|
.name = CHRDEV,
|
|
|
- .attach = pp_attach,
|
|
|
+ .probe = pp_probe,
|
|
|
+ .match_port = pp_attach,
|
|
|
.detach = pp_detach,
|
|
|
+ .devmodel = true,
|
|
|
};
|
|
|
|
|
|
-static int __init ppdev_init (void)
|
|
|
+static int __init ppdev_init(void)
|
|
|
{
|
|
|
int err = 0;
|
|
|
|
|
|
- if (register_chrdev (PP_MAJOR, CHRDEV, &pp_fops)) {
|
|
|
- printk (KERN_WARNING CHRDEV ": unable to get major %d\n",
|
|
|
- PP_MAJOR);
|
|
|
+ if (register_chrdev(PP_MAJOR, CHRDEV, &pp_fops)) {
|
|
|
+ printk(KERN_WARNING CHRDEV ": unable to get major %d\n",
|
|
|
+ PP_MAJOR);
|
|
|
return -EIO;
|
|
|
}
|
|
|
ppdev_class = class_create(THIS_MODULE, CHRDEV);
|
|
@@ -781,11 +836,11 @@ static int __init ppdev_init (void)
|
|
|
}
|
|
|
err = parport_register_driver(&pp_driver);
|
|
|
if (err < 0) {
|
|
|
- printk (KERN_WARNING CHRDEV ": unable to register with parport\n");
|
|
|
+ printk(KERN_WARNING CHRDEV ": unable to register with parport\n");
|
|
|
goto out_class;
|
|
|
}
|
|
|
|
|
|
- printk (KERN_INFO PP_VERSION "\n");
|
|
|
+ printk(KERN_INFO PP_VERSION "\n");
|
|
|
goto out;
|
|
|
|
|
|
out_class:
|
|
@@ -796,12 +851,12 @@ out:
|
|
|
return err;
|
|
|
}
|
|
|
|
|
|
-static void __exit ppdev_cleanup (void)
|
|
|
+static void __exit ppdev_cleanup(void)
|
|
|
{
|
|
|
/* Clean up all parport stuff */
|
|
|
parport_unregister_driver(&pp_driver);
|
|
|
class_destroy(ppdev_class);
|
|
|
- unregister_chrdev (PP_MAJOR, CHRDEV);
|
|
|
+ unregister_chrdev(PP_MAJOR, CHRDEV);
|
|
|
}
|
|
|
|
|
|
module_init(ppdev_init);
|