Эх сурвалжийг харах

[media] tvp7002: Check v4l2_of_parse_endpoint() return value

The v4l2_of_parse_endpoint() function can fail so check the return value.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Javier Martinez Canillas 9 жил өмнө
parent
commit
baf40b5f79

+ 4 - 2
drivers/media/i2c/tvp7002.c

@@ -894,7 +894,7 @@ static struct tvp7002_config *
 tvp7002_get_pdata(struct i2c_client *client)
 tvp7002_get_pdata(struct i2c_client *client)
 {
 {
 	struct v4l2_of_endpoint bus_cfg;
 	struct v4l2_of_endpoint bus_cfg;
-	struct tvp7002_config *pdata;
+	struct tvp7002_config *pdata = NULL;
 	struct device_node *endpoint;
 	struct device_node *endpoint;
 	unsigned int flags;
 	unsigned int flags;
 
 
@@ -905,11 +905,13 @@ tvp7002_get_pdata(struct i2c_client *client)
 	if (!endpoint)
 	if (!endpoint)
 		return NULL;
 		return NULL;
 
 
+	if (v4l2_of_parse_endpoint(endpoint, &bus_cfg))
+		goto done;
+
 	pdata = devm_kzalloc(&client->dev, sizeof(*pdata), GFP_KERNEL);
 	pdata = devm_kzalloc(&client->dev, sizeof(*pdata), GFP_KERNEL);
 	if (!pdata)
 	if (!pdata)
 		goto done;
 		goto done;
 
 
-	v4l2_of_parse_endpoint(endpoint, &bus_cfg);
 	flags = bus_cfg.bus.parallel.flags;
 	flags = bus_cfg.bus.parallel.flags;
 
 
 	if (flags & V4L2_MBUS_HSYNC_ACTIVE_HIGH)
 	if (flags & V4L2_MBUS_HSYNC_ACTIVE_HIGH)