Browse Source

bnxt_en: Remove unwanted ovs-offload messages in some conditions

In some conditions when the driver fails to add a flow in HW and returns
an error back to the stack, the stack continues to invoke get_flow_stats()
and/or del_flow() on it. The driver fails these APIs with an error message
"no flow_node for cookie". The message gets logged repeatedly as long as
the stack keeps invoking these functions.

Fix this by removing the corresponding netdev_info() calls from these
functions.

Fixes: d7bc73053024 ("bnxt_en: add code to query TC flower offload stats")
Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Sriharsha Basavapatna 7 years ago
parent
commit
b9ecc3400b
1 changed files with 2 additions and 8 deletions
  1. 2 8
      drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c

+ 2 - 8
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c

@@ -1269,11 +1269,8 @@ static int bnxt_tc_del_flow(struct bnxt *bp,
 	flow_node = rhashtable_lookup_fast(&tc_info->flow_table,
 	flow_node = rhashtable_lookup_fast(&tc_info->flow_table,
 					   &tc_flow_cmd->cookie,
 					   &tc_flow_cmd->cookie,
 					   tc_info->flow_ht_params);
 					   tc_info->flow_ht_params);
-	if (!flow_node) {
-		netdev_info(bp->dev, "ERROR: no flow_node for cookie %lx",
-			    tc_flow_cmd->cookie);
+	if (!flow_node)
 		return -EINVAL;
 		return -EINVAL;
-	}
 
 
 	return __bnxt_tc_del_flow(bp, flow_node);
 	return __bnxt_tc_del_flow(bp, flow_node);
 }
 }
@@ -1290,11 +1287,8 @@ static int bnxt_tc_get_flow_stats(struct bnxt *bp,
 	flow_node = rhashtable_lookup_fast(&tc_info->flow_table,
 	flow_node = rhashtable_lookup_fast(&tc_info->flow_table,
 					   &tc_flow_cmd->cookie,
 					   &tc_flow_cmd->cookie,
 					   tc_info->flow_ht_params);
 					   tc_info->flow_ht_params);
-	if (!flow_node) {
-		netdev_info(bp->dev, "Error: no flow_node for cookie %lx",
-			    tc_flow_cmd->cookie);
+	if (!flow_node)
 		return -1;
 		return -1;
-	}
 
 
 	flow = &flow_node->flow;
 	flow = &flow_node->flow;
 	curr_stats = &flow->stats;
 	curr_stats = &flow->stats;