瀏覽代碼

regulator: twl6030: fix range comparison, allowing vsel = 59

The range min_uV > 1350000 && min_uV <= 150000 is never reachable
because of a typo in the previous range check and hence vsel = 59
is never reached.  Fix the previous range check to enable the
vsel = 59 setting.

Fixes CoverityScan CID#728454 ("Logially dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Colin Ian King 8 年之前
父節點
當前提交
b98acbff9a
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/regulator/twl6030-regulator.c

+ 1 - 1
drivers/regulator/twl6030-regulator.c

@@ -452,7 +452,7 @@ static int twl6030smps_map_voltage(struct regulator_dev *rdev, int min_uV,
 			vsel = 62;
 			vsel = 62;
 		else if ((min_uV > 1800000) && (min_uV <= 1900000))
 		else if ((min_uV > 1800000) && (min_uV <= 1900000))
 			vsel = 61;
 			vsel = 61;
-		else if ((min_uV > 1350000) && (min_uV <= 1800000))
+		else if ((min_uV > 1500000) && (min_uV <= 1800000))
 			vsel = 60;
 			vsel = 60;
 		else if ((min_uV > 1350000) && (min_uV <= 1500000))
 		else if ((min_uV > 1350000) && (min_uV <= 1500000))
 			vsel = 59;
 			vsel = 59;