Browse Source

btrfs: qgroup: move the qgroup->members check out from (!qgroup)'s else branch

There is no reason to put this check in (!qgroup)'s else branch because
if qgroup is null, it will goto out directly. So move it out to reduce
indentation level.  No functional change.

Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Lu Fengqi 6 years ago
parent
commit
b90e22ba48
1 changed files with 7 additions and 6 deletions
  1. 7 6
      fs/btrfs/qgroup.c

+ 7 - 6
fs/btrfs/qgroup.c

@@ -1416,13 +1416,14 @@ int btrfs_remove_qgroup(struct btrfs_trans_handle *trans, u64 qgroupid)
 	if (!qgroup) {
 	if (!qgroup) {
 		ret = -ENOENT;
 		ret = -ENOENT;
 		goto out;
 		goto out;
-	} else {
-		/* check if there are no children of this qgroup */
-		if (!list_empty(&qgroup->members)) {
-			ret = -EBUSY;
-			goto out;
-		}
 	}
 	}
+
+	/* Check if there are no children of this qgroup */
+	if (!list_empty(&qgroup->members)) {
+		ret = -EBUSY;
+		goto out;
+	}
+
 	ret = del_qgroup_item(trans, qgroupid);
 	ret = del_qgroup_item(trans, qgroupid);
 	if (ret && ret != -ENOENT)
 	if (ret && ret != -ENOENT)
 		goto out;
 		goto out;