Home Explore Help
Sign In
GfA
/
linux_kernel
5
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

sched/fair: Fix typo in sync_throttle()

We should update cfs_rq->throttled_clock_task, not
pcfs_rq->throttle_clock_task.

The effects of this bug was probably occasionally erratic
group scheduling, particularly in cgroups-intense workloads.

Signed-off-by: Xunlei Pang <xlpang@redhat.com>
[ Added changelog. ]
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 55e16d30bd99 ("sched/fair: Rework throttle_count sync")
Link: http://lkml.kernel.org/r/1468050862-18864-1-git-send-email-xlpang@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Xunlei Pang 9 years ago
parent
a23eadfae2
commit
b8922125e4
1 changed files with 1 additions and 1 deletions
Unified View Show Diff Stats
  1. 1 1
      kernel/sched/fair.c

+ 1 - 1
kernel/sched/fair.c
View File 

@@ -4269,7 +4269,7 @@ static void sync_throttle(struct task_group *tg, int cpu)
 
 	pcfs_rq = tg->parent->cfs_rq[cpu];
 
 	pcfs_rq = tg->parent->cfs_rq[cpu];
 
 
 
 	cfs_rq->throttle_count = pcfs_rq->throttle_count;
 
 	cfs_rq->throttle_count = pcfs_rq->throttle_count;
 
-	pcfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu));
 
+	cfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu));
 
 }
 
 }
 
 
 
 /* conditionally throttle active cfs_rq's from put_prev_entity() */
 
 /* conditionally throttle active cfs_rq's from put_prev_entity() */