Эх сурвалжийг харах

drm/nouveau/mpeg: switch to subdev printk macros

Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Ben Skeggs 10 жил өмнө
parent
commit
b835c09bc6

+ 7 - 5
drivers/gpu/drm/nouveau/nvkm/engine/mpeg/nv31.c

@@ -229,9 +229,9 @@ nv31_mpeg_intr(struct nvkm_subdev *subdev)
 	nvkm_wr32(device, 0x00b230, 0x00000001);
 	nvkm_wr32(device, 0x00b230, 0x00000001);
 
 
 	if (show) {
 	if (show) {
-		nv_error(mpeg, "ch %d [%s] 0x%08x 0x%08x 0x%08x 0x%08x\n",
-			 fifo->chid(fifo, engctx),
-			 nvkm_client_name(engctx), stat, type, mthd, data);
+		nvkm_error(subdev, "ch %d [%s] %08x %08x %08x %08x\n",
+			   fifo->chid(fifo, engctx),
+			   nvkm_client_name(engctx), stat, type, mthd, data);
 	}
 	}
 
 
 	spin_unlock_irqrestore(&nv_engine(mpeg)->lock, flags);
 	spin_unlock_irqrestore(&nv_engine(mpeg)->lock, flags);
@@ -263,7 +263,8 @@ nv31_mpeg_init(struct nvkm_object *object)
 {
 {
 	struct nvkm_engine *engine = nv_engine(object);
 	struct nvkm_engine *engine = nv_engine(object);
 	struct nv31_mpeg *mpeg = (void *)object;
 	struct nv31_mpeg *mpeg = (void *)object;
-	struct nvkm_device *device = mpeg->base.engine.subdev.device;
+	struct nvkm_subdev *subdev = &mpeg->base.engine.subdev;
+	struct nvkm_device *device = subdev->device;
 	struct nvkm_fb *fb = device->fb;
 	struct nvkm_fb *fb = device->fb;
 	int ret, i;
 	int ret, i;
 
 
@@ -292,7 +293,8 @@ nv31_mpeg_init(struct nvkm_object *object)
 		if (!(nvkm_rd32(device, 0x00b200) & 0x00000001))
 		if (!(nvkm_rd32(device, 0x00b200) & 0x00000001))
 			break;
 			break;
 	) < 0) {
 	) < 0) {
-		nv_error(mpeg, "timeout 0x%08x\n", nvkm_rd32(device, 0x00b200));
+		nvkm_error(subdev, "timeout %08x\n",
+			   nvkm_rd32(device, 0x00b200));
 		return -EBUSY;
 		return -EBUSY;
 	}
 	}
 
 

+ 1 - 1
drivers/gpu/drm/nouveau/nvkm/engine/mpeg/nv40.c

@@ -98,7 +98,7 @@ nv40_mpeg_intr(struct nvkm_subdev *subdev)
 		nv31_mpeg_intr(subdev);
 		nv31_mpeg_intr(subdev);
 
 
 	if ((stat = nvkm_rd32(device, 0x00b800))) {
 	if ((stat = nvkm_rd32(device, 0x00b800))) {
-		nv_error(mpeg, "PMSRCH 0x%08x\n", stat);
+		nvkm_error(subdev, "PMSRCH %08x\n", stat);
 		nvkm_wr32(device, 0x00b800, stat);
 		nvkm_wr32(device, 0x00b800, stat);
 	}
 	}
 }
 }

+ 5 - 5
drivers/gpu/drm/nouveau/nvkm/engine/mpeg/nv44.c

@@ -126,10 +126,10 @@ nv44_mpeg_intr(struct nvkm_subdev *subdev)
 	nvkm_wr32(device, 0x00b230, 0x00000001);
 	nvkm_wr32(device, 0x00b230, 0x00000001);
 
 
 	if (show) {
 	if (show) {
-		nv_error(mpeg,
-			 "ch %d [0x%08x %s] 0x%08x 0x%08x 0x%08x 0x%08x\n",
-			 chid, inst << 4, nvkm_client_name(engctx), stat,
-			 type, mthd, data);
+		nvkm_error(subdev,
+			   "ch %d [%08x %s] %08x %08x %08x %08x\n",
+			   chid, inst << 4, nvkm_client_name(engctx), stat,
+			   type, mthd, data);
 	}
 	}
 
 
 	nvkm_engctx_put(engctx);
 	nvkm_engctx_put(engctx);
@@ -146,7 +146,7 @@ nv44_mpeg_me_intr(struct nvkm_subdev *subdev)
 		nv44_mpeg_intr(subdev);
 		nv44_mpeg_intr(subdev);
 
 
 	if ((stat = nvkm_rd32(device, 0x00b800))) {
 	if ((stat = nvkm_rd32(device, 0x00b800))) {
-		nv_error(mpeg, "PMSRCH 0x%08x\n", stat);
+		nvkm_error(subdev, "PMSRCH %08x\n", stat);
 		nvkm_wr32(device, 0x00b800, stat);
 		nvkm_wr32(device, 0x00b800, stat);
 	}
 	}
 }
 }

+ 8 - 7
drivers/gpu/drm/nouveau/nvkm/engine/mpeg/nv50.c

@@ -135,8 +135,8 @@ nv50_mpeg_intr(struct nvkm_subdev *subdev)
 	}
 	}
 
 
 	if (show) {
 	if (show) {
-		nv_info(mpeg, "0x%08x 0x%08x 0x%08x 0x%08x\n",
-			stat, type, mthd, data);
+		nvkm_info(subdev, "%08x %08x %08x %08x\n",
+			  stat, type, mthd, data);
 	}
 	}
 
 
 	nvkm_wr32(device, 0x00b100, stat);
 	nvkm_wr32(device, 0x00b100, stat);
@@ -146,15 +146,14 @@ nv50_mpeg_intr(struct nvkm_subdev *subdev)
 static void
 static void
 nv50_vpe_intr(struct nvkm_subdev *subdev)
 nv50_vpe_intr(struct nvkm_subdev *subdev)
 {
 {
-	struct nvkm_mpeg *mpeg = (void *)subdev;
-	struct nvkm_device *device = mpeg->engine.subdev.device;
+	struct nvkm_device *device = subdev->device;
 
 
 	if (nvkm_rd32(device, 0x00b100))
 	if (nvkm_rd32(device, 0x00b100))
 		nv50_mpeg_intr(subdev);
 		nv50_mpeg_intr(subdev);
 
 
 	if (nvkm_rd32(device, 0x00b800)) {
 	if (nvkm_rd32(device, 0x00b800)) {
 		u32 stat = nvkm_rd32(device, 0x00b800);
 		u32 stat = nvkm_rd32(device, 0x00b800);
-		nv_info(mpeg, "PMSRCH: 0x%08x\n", stat);
+		nvkm_info(subdev, "PMSRCH: %08x\n", stat);
 		nvkm_wr32(device, 0xb800, stat);
 		nvkm_wr32(device, 0xb800, stat);
 	}
 	}
 }
 }
@@ -183,7 +182,8 @@ int
 nv50_mpeg_init(struct nvkm_object *object)
 nv50_mpeg_init(struct nvkm_object *object)
 {
 {
 	struct nvkm_mpeg *mpeg = (void *)object;
 	struct nvkm_mpeg *mpeg = (void *)object;
-	struct nvkm_device *device = mpeg->engine.subdev.device;
+	struct nvkm_subdev *subdev = &mpeg->engine.subdev;
+	struct nvkm_device *device = subdev->device;
 	int ret;
 	int ret;
 
 
 	ret = nvkm_mpeg_init(mpeg);
 	ret = nvkm_mpeg_init(mpeg);
@@ -208,7 +208,8 @@ nv50_mpeg_init(struct nvkm_object *object)
 		if (!(nvkm_rd32(device, 0x00b200) & 0x00000001))
 		if (!(nvkm_rd32(device, 0x00b200) & 0x00000001))
 			break;
 			break;
 	) < 0) {
 	) < 0) {
-		nv_error(mpeg, "timeout 0x%08x\n", nvkm_rd32(device, 0x00b200));
+		nvkm_error(subdev, "timeout %08x\n",
+			   nvkm_rd32(device, 0x00b200));
 		return -EBUSY;
 		return -EBUSY;
 	}
 	}