Browse Source

usb: gadget: inode.c: fix unbalanced spin_lock in ep0_write

Fix bad unlock balance: ep0_write enter with the locks locked from
inode.c:1769, hence it must exit with spinlock held to avoid double
unlock in dev_config.

Signed-off-by: David Eccher <d.eccher@gmail.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
David Eccher 9 years ago
parent
commit
b7bd98b7db
1 changed files with 1 additions and 2 deletions
  1. 1 2
      drivers/usb/gadget/legacy/inode.c

+ 1 - 2
drivers/usb/gadget/legacy/inode.c

@@ -1137,10 +1137,9 @@ ep0_write (struct file *fd, const char __user *buf, size_t len, loff_t *ptr)
 						dev->gadget->ep0, dev->req,
 						dev->gadget->ep0, dev->req,
 						GFP_KERNEL);
 						GFP_KERNEL);
 				}
 				}
+				spin_lock_irq(&dev->lock);
 				if (retval < 0) {
 				if (retval < 0) {
-					spin_lock_irq (&dev->lock);
 					clean_req (dev->gadget->ep0, dev->req);
 					clean_req (dev->gadget->ep0, dev->req);
-					spin_unlock_irq (&dev->lock);
 				} else
 				} else
 					retval = len;
 					retval = len;