Browse Source

hwmon: (ina2xx) use DIV_ROUND_CLOSEST() to avoid rounding errors

Use DIV_ROUND_CLOSEST() when dealing with the calibration values to make the
calculations less error prone.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Bartosz Golaszewski 10 years ago
parent
commit
b721fe2a3a
1 changed files with 7 additions and 3 deletions
  1. 7 3
      drivers/hwmon/ina2xx.c

+ 7 - 3
drivers/hwmon/ina2xx.c

@@ -186,8 +186,11 @@ static void ina226_set_update_interval(struct ina2xx_data *data)
 
 
 static int ina2xx_calibrate(struct ina2xx_data *data)
 static int ina2xx_calibrate(struct ina2xx_data *data)
 {
 {
-	return i2c_smbus_write_word_swapped(data->client, INA2XX_CALIBRATION,
-			data->config->calibration_factor / data->rshunt);
+	u16 val = DIV_ROUND_CLOSEST(data->config->calibration_factor,
+				    data->rshunt);
+
+	return i2c_smbus_write_word_swapped(data->client,
+					    INA2XX_CALIBRATION, val);
 }
 }
 
 
 /*
 /*
@@ -307,7 +310,8 @@ static int ina2xx_get_value(struct ina2xx_data *data, u8 reg)
 		val = (s16)data->regs[reg];
 		val = (s16)data->regs[reg];
 		break;
 		break;
 	case INA2XX_CALIBRATION:
 	case INA2XX_CALIBRATION:
-		val = data->config->calibration_factor / data->regs[reg];
+		val = DIV_ROUND_CLOSEST(data->config->calibration_factor,
+					data->regs[reg]);
 		break;
 		break;
 	default:
 	default:
 		/* programmer goofed */
 		/* programmer goofed */