Эх сурвалжийг харах

e100: Cocci spatch "pool_zalloc-simple"

Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0.
Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci"

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Thomas Meyer 8 жил өмнө
parent
commit
b6cd4b5895

+ 2 - 3
drivers/net/ethernet/intel/e100.c

@@ -1910,11 +1910,10 @@ static int e100_alloc_cbs(struct nic *nic)
 	nic->cb_to_use = nic->cb_to_send = nic->cb_to_clean = NULL;
 	nic->cb_to_use = nic->cb_to_send = nic->cb_to_clean = NULL;
 	nic->cbs_avail = 0;
 	nic->cbs_avail = 0;
 
 
-	nic->cbs = pci_pool_alloc(nic->cbs_pool, GFP_KERNEL,
-				  &nic->cbs_dma_addr);
+	nic->cbs = pci_pool_zalloc(nic->cbs_pool, GFP_KERNEL,
+				   &nic->cbs_dma_addr);
 	if (!nic->cbs)
 	if (!nic->cbs)
 		return -ENOMEM;
 		return -ENOMEM;
-	memset(nic->cbs, 0, count * sizeof(struct cb));
 
 
 	for (cb = nic->cbs, i = 0; i < count; cb++, i++) {
 	for (cb = nic->cbs, i = 0; i < count; cb++, i++) {
 		cb->next = (i + 1 < count) ? cb + 1 : nic->cbs;
 		cb->next = (i + 1 < count) ? cb + 1 : nic->cbs;