Browse Source

perf symbols: Rename ->ignore to ->idle

Since this is the only use thus far, and this mechanism is in place for
a long time. To clarify why symbols should be skipped or treated
differently, name it for the only use it has.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-oqpf82x2svir611ry15paufd@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Arnaldo Carvalho de Melo 9 years ago
parent
commit
b55cc4ed20
3 changed files with 5 additions and 5 deletions
  1. 2 2
      tools/perf/builtin-top.c
  2. 2 2
      tools/perf/util/evsel_fprintf.c
  3. 1 1
      tools/perf/util/symbol.h

+ 2 - 2
tools/perf/builtin-top.c

@@ -680,7 +680,7 @@ static int symbol_filter(struct map *map, struct symbol *sym)
 		return 1;
 		return 1;
 
 
 	if (symbol__is_idle(sym))
 	if (symbol__is_idle(sym))
-		sym->ignore = true;
+		sym->idle = 1;
 
 
 	return 0;
 	return 0;
 }
 }
@@ -783,7 +783,7 @@ static void perf_event__process_sample(struct perf_tool *tool,
 		}
 		}
 	}
 	}
 
 
-	if (al.sym == NULL || !al.sym->ignore) {
+	if (al.sym == NULL || !al.sym->idle) {
 		struct hists *hists = evsel__hists(evsel);
 		struct hists *hists = evsel__hists(evsel);
 		struct hist_entry_iter iter = {
 		struct hist_entry_iter iter = {
 			.evsel		= evsel,
 			.evsel		= evsel,

+ 2 - 2
tools/perf/util/evsel_fprintf.c

@@ -122,7 +122,7 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment,
 			if (!node)
 			if (!node)
 				break;
 				break;
 
 
-			if (node->sym && node->sym->ignore)
+			if (node->sym && node->sym->idle)
 				goto next;
 				goto next;
 
 
 			printed += fprintf(fp, "%-*.*s", left_alignment, left_alignment, " ");
 			printed += fprintf(fp, "%-*.*s", left_alignment, left_alignment, " ");
@@ -181,7 +181,7 @@ int sample__fprintf_sym(struct perf_sample *sample, struct addr_location *al,
 	if (cursor != NULL) {
 	if (cursor != NULL) {
 		printed += sample__fprintf_callchain(sample, left_alignment,
 		printed += sample__fprintf_callchain(sample, left_alignment,
 						     print_opts, cursor, fp);
 						     print_opts, cursor, fp);
-	} else if (!(al->sym && al->sym->ignore)) {
+	} else if (!(al->sym && al->sym->idle)) {
 		printed += fprintf(fp, "%-*.*s", left_alignment, left_alignment, " ");
 		printed += fprintf(fp, "%-*.*s", left_alignment, left_alignment, " ");
 
 
 		if (print_ip)
 		if (print_ip)

+ 1 - 1
tools/perf/util/symbol.h

@@ -57,7 +57,7 @@ struct symbol {
 	u64		end;
 	u64		end;
 	u16		namelen;
 	u16		namelen;
 	u8		binding;
 	u8		binding;
-	bool		ignore;
+	u8		idle:1;
 	u8		arch_sym;
 	u8		arch_sym;
 	char		name[0];
 	char		name[0];
 };
 };